Skip to content

Fix 0 fps - #2054

Merged
reinecke merged 1 commit into
AcademySoftwareFoundation:mainfrom
O-Minor:fix-0-fps
Sep 21, 2026
Merged

reinecke merged 1 commit into
AcademySoftwareFoundation:mainfrom
O-Minor:fix-0-fps

Conversation

@O-Minor

@O-Minor O-Minor commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

The list of valid FPS values had allocated 11 elements but 1 element was not used so it was auto filled with the value 0, allowing 0 fps as a valid value.

Tests: Added tests for value that rounds to 0, 0 itself, and negative value that rounds to zero inside the test that checks for correct rounding, correct value for all of these should be the value a little under 24.

Fix: Changed number of elements of the list from 11 to 10 to get rid of the hidden 0 entry.

All tests passed in the CI.

@codecov-commenter

codecov-commenter commented Sep 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.52%. Comparing base (8ab0cf9) to head (e5f6915).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2054   +/-   ##
=======================================
  Coverage   83.52%   83.52%           
=======================================
  Files         182      182           
  Lines       13533    13533           
  Branches     1255     1255           
=======================================
  Hits        11303    11303           
  Misses       2057     2057           
  Partials      173      173           
Flag Coverage Δ
py-unittests 83.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/opentime/rationalTime.cpp 84.76% <ø> (ø)
tests/test_opentime.py 99.75% <ø> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ab0cf9...e5f6915. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@O-Minor
O-Minor force-pushed the fix-0-fps branch 2 times, most recently from 82658c1 to c20fa2f Compare September 19, 2026 21:08
@O-Minor
O-Minor marked this pull request as ready for review September 19, 2026 21:21
@O-Minor O-Minor changed the title Draft: Fix 0 fps Fix 0 fps Sep 19, 2026
Signed-off-by: Opal Oliver Minor <42308423+O-Minor@users.noreply.github.com>
@reinecke
reinecke merged commit b424801 into AcademySoftwareFoundation:main Sep 21, 2026
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants