Skip to content

feat: added icons and api - #2732

Open
RohitKushvaha01 wants to merge 6 commits into
Acode-Foundation:mainfrom
RohitKushvaha01:add-app-icons
Open

feat: added icons and api#2732
RohitKushvaha01 wants to merge 6 commits into
Acode-Foundation:mainfrom
RohitKushvaha01:add-app-icons

Conversation

@RohitKushvaha01

Copy link
Copy Markdown
Member

No description provided.

@greptile-apps

greptile-apps Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR adds selectable Android launcher icons and exposes icon switching through the bundled System plugin.

  • Adds adaptive and density-specific launcher icon resources with manifest activity aliases.
  • Adds the native and JavaScript setAppIcon bridge.
  • Adds the app-icon settings page, persistence, localization, and unit coverage.
  • Replaces the Android-incompatible Map.of initializer with supported collection APIs.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
src/plugins/system/android/com/foxdebug/system/System.java Adds activity-alias switching and now initializes the icon map using APIs supported across the configured Android API range.
config.xml Declares launcher activity aliases for the default and alternate app icons.
hooks/post-process.js Removes the generated MainActivity launcher filter so aliases exclusively own launcher entry points.
src/lib/appIcons.js Defines the application-side icon catalog and icon-switching interface.
src/pages/appIconSetting/appIconSetting.js Implements the user-facing icon selection page.
src/lib/settings.js Persists the selected app-icon preference through the existing settings store.
src/plugins/system/www/plugin.js Exposes the native set-app-icon action through the Cordova JavaScript bridge.

Sequence Diagram

sequenceDiagram
    participant User
    participant Settings as App icon settings
    participant Bridge as System JS bridge
    participant Native as System.java
    participant Android as PackageManager
    User->>Settings: Select launcher icon
    Settings->>Bridge: setAppIcon(iconName)
    Bridge->>Native: cordova.exec("set-app-icon")
    Native->>Android: Toggle activity-alias components
    Android-->>User: Display selected launcher icon
Loading

Reviews (2): Last reviewed commit: "Merge branch 'main' into add-app-icons" | Re-trigger Greptile

Comment thread src/plugins/system/android/com/foxdebug/system/System.java Outdated
@RohitKushvaha01
RohitKushvaha01 marked this pull request as draft August 13, 2026 13:18
@RohitKushvaha01
RohitKushvaha01 marked this pull request as ready for review August 21, 2026 11:00
@RohitKushvaha01

Copy link
Copy Markdown
Member Author

@greptile-apps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

1 participant