Skip to content

Bump Rust toolchain to 1.98.1 (lance 12 blocked on arrow/DF migration) - #178

Merged
AdaWorldAPI merged 2 commits into
mainfrom
claude/llvm-codegen-polyfill-gni3cw
Sep 25, 2026
Merged

AdaWorldAPI merged 2 commits into
mainfrom
claude/llvm-codegen-polyfill-gni3cw

Conversation

@AdaWorldAPI

Copy link
Copy Markdown
Owner

This PR moves ladybug-rs to Rust 1.98.1 as part of the workspace-wide bump. What changes:

  • rust-toolchain.toml is now 1.98.1.
  • rust-version is 1.98.1 in the root crate and in ladybug-contract.
  • All 6 Dockerfiles build from rust:1.98.1-slim-bookworm.
  • The ci-master.yml and proof.yml toolchains are 1.98.1.

lance is NOT bumped to 12 in this PR. lance 12 needs arrow ^58 and datafusion ^54. ladybug-rs is on arrow 57 and datafusion 51, so pinning lance 12 alone would leave the dependency graph unresolvable. Moving arrow and datafusion is a separate migration and needs its own decision. I left a comment at the pin in Cargo.toml explaining this.

I did not build this repo locally. Its path dependencies need sibling checkouts; see this repo's CLAUDE.md §1.

🤖 Generated with Claude Code

https://claude.ai/code/session_019HnekoM1EidTwQLS3oFVFm


Generated by Claude Code

Workspace-wide sweep to 1.98.1 (rust-toolchain, rust-version, Dockerfile
base images, CI MSRV pins). Docker tags rust:1.98.1, -bookworm and
-slim-bookworm verified to exist.
lance stays at 2.0 here: lance 12 needs arrow ^58 / datafusion ^54, and this
crate is on arrow 57 / datafusion 51. The lance bump lands with that
migration, not alone (comment added at the pin).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019HnekoM1EidTwQLS3oFVFm
@cursor

cursor Bot commented Sep 25, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_fbefdb50-e3fc-4ac5-8cf5-b37e8caa79e8)

@AdaWorldAPI
AdaWorldAPI marked this pull request as ready for review September 25, 2026 02:14
… main's side)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019HnekoM1EidTwQLS3oFVFm

Copy link
Copy Markdown
Owner Author

The failing Build and Compile Check jobs are not caused by this PR. Both fail with Could not find protoc while compiling a build script. The runner has no protobuf-compiler installed. The same two jobs, plus build, CI Summary and Proof Summary, are red on main's head with the identical failure.

This PR changes only toolchain pins (rust-toolchain, rust-version, Dockerfile tags, the CI toolchain input), not dependencies. No fix exists yet. The proposed patch is an apt-get install -y protobuf-compiler libprotobuf-dev step before the cargo steps in each affected workflow. I've left that out of this PR so it stays a toolchain-only change, and it belongs in its own PR.


Generated by Claude Code

@AdaWorldAPI
AdaWorldAPI merged commit b95eb70 into main Sep 25, 2026
7 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants