Skip to content

lgj-abi: status arms for the new mask-risc ExecError variants (Wave 4 base) - #83

Merged
AdaWorldAPI merged 3 commits into
mainfrom
claude/fold-distillation-pr-wave-s57uj7
Sep 22, 2026
Merged

AdaWorldAPI merged 3 commits into
mainfrom
claude/fold-distillation-pr-wave-s57uj7

Conversation

@AdaWorldAPI

Copy link
Copy Markdown
Owner

exec_error_to_status gains arms for ForeignOutOfRange, ForeignLaneOutOfRange, ForeignLaneKind and TerminalNeedsOut, mapped onto the codes their Planes-side twins already use. No new codes, no ABI bump.

Depends on lance-graph #1256 (the variants live there); CI is red against lance-graph main until it merges. Verified locally against #1256's head: cargo test -p lgj-abi 188 checks, clippy -D warnings clean, and the Java suite ALL PASSED (409 checks) on JDK 28+16 with --enable-preview (Valhalla value records + Panama FFM) against the rebuilt liblgj_abi.so (abi 0.11, ndarray::simd avx512).

Wave 4 (Java groupBy/join over the same Quack lowering) lands on this branch next.

🤖 Generated with Claude Code

https://claude.ai/code/session_01GXUahz73MZxtxWcfpHp9dG


Generated by Claude Code

…codes

Foreign/ForeignLane out-of-range and kind, and TerminalNeedsOut, land on
the codes their Planes-side twins already use. No new codes, no ABI bump.
Depends on lance-graph #1256 (the variants live there).

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GXUahz73MZxtxWcfpHp9dG
@coderabbitai

coderabbitai Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: 1d707181-d6a8-40b0-b611-51b3384e1029

📥 Commits

Reviewing files that changed from the base of the PR and between e1f909f and 4cae6da.

📒 Files selected for processing (3)
  • native/lgj-abi/src/exports.rs
  • native/lgj-abi/src/exports/tests/lowering_convergence.rs
  • native/lgj-abi/src/plan_lower.rs
 _____________________________________________________________________
< This is 'temporary' in the same way legacy systems are 'temporary'. >
 ---------------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@cursor

cursor Bot commented Sep 21, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_06529232-40fe-4da6-96bb-e200ebb6f047)

Copy link
Copy Markdown
Owner Author

CI status on 183745e: clippy and rust-test fail with E0599: no variant named ForeignOutOfRange / ForeignLaneOutOfRange / ForeignLaneKind / TerminalNeedsOut in lance_graph_mask_risc::ExecError. Not this PR's defect: CI checks out lance-graph main, and those variants land with lance-graph #1256 (which itself waits on ndarray #318). The fix is the merge order (#318 → #1256 → this); nothing to port here. Verified locally against #1256's head: lgj-abi 188 checks and the Java suite 409 checks green on JDK 28 with --enable-preview. Will stay watched until green.


Generated by Claude Code

…stination resource

The destination mask is the demanded result, so the lowering ends in
Keep and the executor writes it tile by tile into the resource's own
words (Out::Mask); the count is a popcount over that sink. The scratch
is SLOTS × tile_words_for(rows) — no population-sized scratch, no copy
from a slot into the resource. The scalar oracle arm answers the same
way through reference_execute_into. Validation stays total before the
first tile, so an error leaves dst_mask untouched as before.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GXUahz73MZxtxWcfpHp9dG
mask-risc's `CountKeyRunsU32` now refuses a key lane out of key order; the
ABI reports it as the lane-shape mismatch it is.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GXUahz73MZxtxWcfpHp9dG
@cursor

cursor Bot commented Sep 21, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_f3cc2542-e7c2-4334-8b1a-f5d290a3bbc1)

@AdaWorldAPI
AdaWorldAPI marked this pull request as ready for review September 22, 2026 04:29
@cursor

cursor Bot commented Sep 22, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_6310f8b3-3504-47ae-8b21-a536824293af)

@AdaWorldAPI
AdaWorldAPI merged commit 07e044f into main Sep 22, 2026
7 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants