Skip to content

jc: as_chunks_mut in the two fingerprint builders (clears JC Substrate Proof on main) - #1274

Merged
AdaWorldAPI merged 1 commit into
mainfrom
claude/fold-distillation-pr-wave-s57uj7
Sep 23, 2026
Merged

AdaWorldAPI merged 1 commit into
mainfrom
claude/fold-distillation-pr-wave-s57uj7

Conversation

@AdaWorldAPI

Copy link
Copy Markdown
Owner

Why

JC Substrate Proof (jc-proof.yml) has been red on every push to main since at least 2026-09-22, including 9b6acb58. The failure is lint clippy::chunks_exact_to_as_chunks, which is new in 1.98, and it fires in crates/jc. jc is workspace-excluded, so the workspace-scoped pre-bump sweep never checked it. The issue was already recorded as TD-JC-CLIPPY-RED-ON-BASE-2, which spelled out this fix.

Change

  • jirak.rs deterministic_fingerprint and pearl.rs fingerprint now iterate fp.as_chunks_mut::<8>().0 and write each [u8; 8] directly. The bytes are the same as before, because chunks_exact_mut also ignored any remainder.
  • TECH_DEBT.md: the entry is marked RESOLVED for jc only. Its census of 116 ungated sites in other excluded crates stays open.

Verification (local, toolchain 1.98.1)

  • Unfixed tree: the lint reproduces under --all-targets -D warnings.
  • Fixed tree, running every step of the workflow: cargo test (141 + 17 passed), clippy clean, prove_it exits 0, substrate_compare exits 0. cargo fmt --check is clean.

Not related to #1270/#1272. The other non-green check on main, member-tests, shows all 56 test results ok and was cancelled during cache save. It passed on c47698fa.

🤖 Generated with Claude Code

https://claude.ai/code/session_01GXUahz73MZxtxWcfpHp9dG


Generated by Claude Code

…e Proof on main)

clippy 1.98 added `chunks_exact_to_as_chunks`, and `jc` is workspace-excluded,
so the workspace-scoped pre-bump sweep never reached it. `jc-proof.yml` runs
its own clippy step under `-D warnings` and has been red on every main push
since. Recorded as TD-JC-CLIPPY-RED-ON-BASE-2 (2026-09-18).

Both `deterministic_fingerprint` (jirak.rs) and `fingerprint` (pearl.rs) now
iterate `fp.as_chunks_mut::<8>().0`, writing each `[u8; 8]` directly. Same
bytes as before: `chunks_exact_mut` also skipped any remainder.

Verified locally: the unfixed tree reproduces the lint; the fixed tree passes
every step of the workflow (tests 141 + 17, clippy --all-targets, prove_it,
substrate_compare).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GXUahz73MZxtxWcfpHp9dG
@coderabbitai

coderabbitai Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: 345c83c9-e1ad-4d6d-8b4c-4109e22dccd9

📥 Commits

Reviewing files that changed from the base of the PR and between 9b6acb5 and 6a5e9a3.

📒 Files selected for processing (3)
  • .claude/board/TECH_DEBT.md
  • crates/jc/src/jirak.rs
  • crates/jc/src/pearl.rs
 ___________________________
< Clippy has nothing on me. >
 ---------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@cursor

cursor Bot commented Sep 23, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_b918958c-9828-4952-8c44-03fb618cb070)

@AdaWorldAPI
AdaWorldAPI marked this pull request as ready for review September 23, 2026 19:28
@AdaWorldAPI
AdaWorldAPI merged commit 16b8539 into main Sep 23, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants