jc: as_chunks_mut in the two fingerprint builders (clears JC Substrate Proof on main) - #1274
Merged
Merged
Conversation
…e Proof on main) clippy 1.98 added `chunks_exact_to_as_chunks`, and `jc` is workspace-excluded, so the workspace-scoped pre-bump sweep never reached it. `jc-proof.yml` runs its own clippy step under `-D warnings` and has been red on every main push since. Recorded as TD-JC-CLIPPY-RED-ON-BASE-2 (2026-09-18). Both `deterministic_fingerprint` (jirak.rs) and `fingerprint` (pearl.rs) now iterate `fp.as_chunks_mut::<8>().0`, writing each `[u8; 8]` directly. Same bytes as before: `chunks_exact_mut` also skipped any remainder. Verified locally: the unfixed tree reproduces the lint; the fixed tree passes every step of the workflow (tests 141 + 17, clippy --all-targets, prove_it, substrate_compare). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GXUahz73MZxtxWcfpHp9dG
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches📝 Generate docstrings
Comment |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_b918958c-9828-4952-8c44-03fb618cb070) |
AdaWorldAPI
marked this pull request as ready for review
September 23, 2026 19:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
JC Substrate Proof(jc-proof.yml) has been red on every push to main since at least 2026-09-22, including9b6acb58. The failure is lintclippy::chunks_exact_to_as_chunks, which is new in 1.98, and it fires incrates/jc.jcis workspace-excluded, so the workspace-scoped pre-bump sweep never checked it. The issue was already recorded asTD-JC-CLIPPY-RED-ON-BASE-2, which spelled out this fix.Change
jirak.rsdeterministic_fingerprintandpearl.rsfingerprintnow iteratefp.as_chunks_mut::<8>().0and write each[u8; 8]directly. The bytes are the same as before, becausechunks_exact_mutalso ignored any remainder.TECH_DEBT.md: the entry is marked RESOLVED forjconly. Its census of 116 ungated sites in other excluded crates stays open.Verification (local, toolchain 1.98.1)
--all-targets -D warnings.cargo test(141 + 17 passed), clippy clean,prove_itexits 0,substrate_compareexits 0.cargo fmt --checkis clean.Not related to #1270/#1272. The other non-green check on main,
member-tests, shows all 56 test resultsokand was cancelled during cache save. It passed onc47698fa.🤖 Generated with Claude Code
https://claude.ai/code/session_01GXUahz73MZxtxWcfpHp9dG
Generated by Claude Code