Skip to content

planner: fix moore_tenant_isa_equivalence for the strict ISA (main build break) - #1409

Merged
AdaWorldAPI merged 2 commits into
mainfrom
ccr-b2e415d9-4jfvyk-tenants-fix
Oct 8, 2026
Merged

AdaWorldAPI merged 2 commits into
mainfrom
ccr-b2e415d9-4jfvyk-tenants-fix

Conversation

@AdaWorldAPI

@AdaWorldAPI AdaWorldAPI commented Oct 8, 2026 •

Copy link
Copy Markdown
Owner

#1407 and #1408 merged one after the other. #1408 went in at 75c83c4, which predates the commit that adapts test J to #1407's forward(...) -> Result. As a result, main (a76d9ab5) no longer compiles lance-graph-planner's moore_tenant_isa_equivalence test:

error[E0609]: no field `0` on type `Result<CausalEdge64, IsaFault>`

This PR carries the two commits that missed the merge, cherry-picked onto main:

  • e60f2ff: J draws only the five executable mantissas (+1, +2, -1, +4, +5) and unwraps forward. Re-verified that cutting the energy field to 3 bits still turns J red.
  • c869458: the board entry now says moore_tenant.rs has 11 tests, and the stale "J follows when CE64 ISA: strict decoder, register methods, field contracts #1407 lands" note is removed.

Local results on this branch:

  • cargo test -p lance-graph-planner --test moore_tenant_isa_equivalence: 2 passed.
  • clippy -D warnings on that test target: clean.
  • Other planner test targets have pre-existing clippy findings that this PR does not touch.

🤖 Generated with Claude Code

https://claude.ai/code/session_01EFw2WdKr1oxvaKCJC2ua2R


Generated by Claude Code

Summary by CodeRabbit

  • Tests
    • Updated graph-planner equivalence testing to use executable edge codes and verify that edge traversal succeeds before checking its results.
    • Adjusted the reported test count in the project’s internal tracking notes.

claude added 2 commits October 8, 2026 09:00
forward() now returns Result and refuses non-executable codes, so the
fixture draws only the five executable mantissas and unwraps the result.
Re-verified: the energy-3-bit disable still turns J red.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EFw2WdKr1oxvaKCJC2ua2R
@coderabbitai

coderabbitai Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 1 files. (2 skipped: 2… Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the planner test fix and the strict ISA build break addressed by the changes.
Full details: Docstring Coverage

Explanation

Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 1 files. (2 skipped: 2 unsupported.)

  • Fix all pre-merge checks with AI
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@AdaWorldAPI
AdaWorldAPI marked this pull request as ready for review October 8, 2026 09:09
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-08T09:11:13.575201Z c869458 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@AdaWorldAPI
AdaWorldAPI merged commit 08e1626 into main Oct 8, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants