Repository navigation
planner: fix moore_tenant_isa_equivalence for the strict ISA (main build break) - #1409
Merged
Merged
Conversation
forward() now returns Result and refuses non-executable codes, so the fixture draws only the five executable mantissas and unwraps the result. Re-verified: the energy-3-bit disable still turns J red. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EFw2WdKr1oxvaKCJC2ua2R
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EFw2WdKr1oxvaKCJC2ua2R
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 1 files. (2 skipped: 2 unsupported.)
Comment |
AdaWorldAPI
marked this pull request as ready for review
October 8, 2026 09:09
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1407 and #1408 merged one after the other. #1408 went in at
75c83c4, which predates the commit that adapts test J to #1407'sforward(...) -> Result. As a result,main(a76d9ab5) no longer compileslance-graph-planner'smoore_tenant_isa_equivalencetest:This PR carries the two commits that missed the merge, cherry-picked onto
main:e60f2ff: J draws only the five executable mantissas (+1, +2, -1, +4, +5) and unwrapsforward. Re-verified that cutting the energy field to 3 bits still turns J red.c869458: the board entry now saysmoore_tenant.rshas 11 tests, and the stale "J follows when CE64 ISA: strict decoder, register methods, field contracts #1407 lands" note is removed.Local results on this branch:
cargo test -p lance-graph-planner --test moore_tenant_isa_equivalence: 2 passed.-D warningson that test target: clean.🤖 Generated with Claude Code
https://claude.ai/code/session_01EFw2WdKr1oxvaKCJC2ua2R
Generated by Claude Code
Summary by CodeRabbit