fix: archive edit accessibility and re-render/re-parse performance - #266
Merged
Merged
Conversation
Fixes several accessibility gaps and unmemoized re-render/re-parse patterns in the archived-day and archived-task editing UI, per audit handoff. - Remove unsafe autoFocus on ArchiveEditDialog's Restore button - Add aria-expanded/aria-controls to the day-summary and per-task edit disclosure toggles - Add scope="col" and an accessible name to the tasks table - Memoize the day/task dirty-check and task save/delete/toggle callbacks - Wrap ArchivedTaskRow and MarkdownDisplay in React.memo so expanding one row no longer re-renders every sibling or re-parses unrelated markdown - Add a same-row Confirm/Cancel step to per-task delete, matching the destructive-action pattern used elsewhere in the app Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019EovqUj4apuAhr3oBuVhQi
github-actions
Bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes several accessibility gaps and unmemoized re-render/re-parse patterns
in the archived-day and archived-task editing UI, per audit handoff.
disclosure toggles
row no longer re-renders every sibling or re-parses unrelated markdown
destructive-action pattern used elsewhere in the app
Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_019EovqUj4apuAhr3oBuVhQi