fix: address v2.8.0 release review findings - #85
Merged
Conversation
|
Addressing review findings is important for release quality. LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v2.8.0 package declared Pydantic 1 compatibility while importing Pydantic 2 APIs, and its exported typed inline-tool models were rejected by every AgentKit LLM vendor before serialization. This requires Pydantic 2.7.1+, accepts dictionary and typed tool definitions across global and CN vendors, recursively serializes typed tools, rejects ambiguous nested ASR keywords, and corrects the release documentation.
Validation: