Skip to content

Skip recording DNS noise for private IP literals with no pending port - #325

Merged
hansott merged 3 commits into
mainfrom
fix/dns-noise-private-ip-only
Jul 27, 2026
Merged

Skip recording DNS noise for private IP literals with no pending port#325
hansott merged 3 commits into
mainfrom
fix/dns-noise-private-ip-only

Conversation

@Mishenevd

@Mishenevd Mishenevd commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Minimal, smaller version of #317 — skips dashboard noise from private-IP-literal DNS lookups with no pending port, everything else (outbound blocking, SSRF checks, port-based recording) stays unconditional and unchanged.

Summary by Aikido

Security Issues: 0 🔍 Quality Issues: 1 Resolved Issues: 0

⚡ Enhancements

  • Skipped recording hostname hits for private IP literals without pending ports

📚 Documentation

  • Clarified why outbound domain blocking was checked at DNS sink

More info

@codecov

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Mishenevd
Mishenevd force-pushed the fix/dns-noise-private-ip-only branch from 758e215 to 608a268 Compare July 23, 2026 12:21
Comment thread agent_api/src/main/java/dev/aikido/agent_api/collectors/DNSRecordCollector.java Outdated
Private IP literal hostnames with no pending port (resolver bootstrap
noise, network capability probing, etc.) flood the outbound-connections
dashboard. Outbound domain blocking and SSRF detection stay fully
unconditional either way - only the dashboard hit is skipped.
@Mishenevd
Mishenevd force-pushed the fix/dns-noise-private-ip-only branch from 608a268 to 39d0c25 Compare July 23, 2026 12:23
@hansott
hansott merged commit d86ba42 into main Jul 27, 2026
479 of 480 checks passed
@hansott
hansott deleted the fix/dns-noise-private-ip-only branch July 27, 2026 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants