Skip to content

fix(load): respect tooltip-format config - #5331

Open
kylin-liwn wants to merge 1 commit into
Alexays:masterfrom
kylin-liwn:fix/load-tooltip
Open

kylin-liwn wants to merge 1 commit into
Alexays:masterfrom
kylin-liwn:fix/load-tooltip

Conversation

@kylin-liwn

Copy link
Copy Markdown

What does this PR do?
The load module called label_.set_tooltip_markup() with a hardcoded format. It never called resolveTooltipFormat(), so the user's tooltip-format config was silently ignored.

Replace the direct call with setTooltipMarkup() paired with resolveTooltipFormat(). Use the configured format when present, fall back to the original default.

Related issues
Closes #5289

Checklist

  • Code is formatted with clang-format
  • Builds locally (ninja -C build)
  • Man page updated for any new/changed user-facing option (man/)
  • Tested against the affected module(s)

The load module called label_.set_tooltip_markup() with a hardcoded
format. It never called resolveTooltipFormat(), so the user's
tooltip-format config was silently ignored.

Replace the direct call with setTooltipMarkup() paired with
resolveTooltipFormat(). Use the configured format when present,
fall back to the original default.
@greptile-apps

greptile-apps Bot commented Sep 17, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with no actionable correctness, security, or repository-rule issues identified.

Summary

This PR updates the load module to honor configured tooltip formats while retaining its existing generated tooltip as the fallback.

  • Resolves state-specific and general tooltip formats through the shared module helper.
  • Formats configured tooltips using the load and icon argument store.
  • Uses the deduplicating tooltip update path employed by other label modules.

Reviews (1) · Last reviewed commit: "fix(load): respect tooltip-format config"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot change cpu tooltip format

1 participant