Repository navigation
Fix display fans across wire-trimmed quadric patches - #16010
Merged
sawenzel merged 1 commit intoOct 26, 2026
Merged
Conversation
This fixes a problem in the display mesh of wire-trimmed quadric patches and adds a unit test. - The trim loop was ear-clipped by taking the first valid ear, which fans a rectangular trim from one corner. - The last triangle of such a fan spans the whole phi sweep and covers the bore in ROOT's GL view. - The clipping now takes the valid ear whose new diagonal has the shortest 3D chord. - Vertices and their order are unchanged, so navigation and safety are not affected. - If the clipping stalls on a wire, it falls back to the plain triangulation, so no triangle is lost. https://its.cern.ch/jira/browse/O2-7284 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sawenzel
force-pushed
the
swenzel/o2-7284-trim-display-fans
branch
from
October 26, 2026 14:45
9317658 to
9f50dcf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a problem in the display mesh of wire-trimmed quadric patches and adds a unit test.
https://its.cern.ch/jira/browse/O2-7284