Skip to content

[PWGDQ] fix bug in FillHistClass #17185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcoquet642 merged 1 commit into from
Jul 24, 2026
+4 −9
Merged

[PWGDQ] fix bug in FillHistClass #17185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions PWGDQ/Core/HistogramManager.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -812,7 +812,6 @@ void HistogramManager::FillHistClass(const char* className, float* values)
bool isProfile = false;
bool isTHn = false;
int dimension = 0;
bool isSparse = kFALSE;
bool isFillLabelx = kFALSE;
// TODO: At the moment, maximum 20 dimensions are foreseen for the THn histograms. We should make this more dynamic
// But maybe its better to have it like to avoid dynamically allocating this array in the histogram loop
Expand Down Expand Up @@ -950,18 +949,14 @@ void HistogramManager::FillHistClass(const char* className, float* values)
// end if(!isTHn)
} else {
if (varW > kNothing) {
if (isSparse) {
if (auto* hn = dynamic_cast<THnSparse*>(h)) {
hn->Fill(fillValues.data(), values[varW]);
}
if (auto* hn = dynamic_cast<THnSparse*>(h)) {
hn->Fill(fillValues.data(), values[varW]);
} else if (auto* hn = dynamic_cast<THn*>(h)) {
hn->Fill(fillValues.data(), values[varW]);
}
} else {
if (isSparse) {
if (auto* hn = dynamic_cast<THnSparse*>(h)) {
hn->Fill(fillValues.data());
}
if (auto* hn = dynamic_cast<THnSparse*>(h)) {
hn->Fill(fillValues.data());
} else if (auto* hn = dynamic_cast<THn*>(h)) {
hn->Fill(fillValues.data());
}
Expand Down
Loading