Skip to content

[ALICE3] Add option to smear and add charged Xi and Sigma to the track table in otf tracker#17199

Merged
jesgum merged 1 commit into
AliceO2Group:masterfrom
jesgum:otf-tracker-dev01
Jul 24, 2026
Merged

[ALICE3] Add option to smear and add charged Xi and Sigma to the track table in otf tracker#17199
jesgum merged 1 commit into
AliceO2Group:masterfrom
jesgum:otf-tracker-dev01

Conversation

@jesgum

@jesgum jesgum commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 31 errors, ⚠️ 23 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Add option to smear and add charged Xi and Sigma to the track table in otf tracker [ALICE3] Add option to smear and add charged Xi and Sigma to the track table in otf tracker Jul 24, 2026
@jesgum
jesgum enabled auto-merge (squash) July 24, 2026 16:17

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @jesgum.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 5537e5c at 2026-07-24 18:28:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 72 errors and 8 warnings.'
Found 72 errors and 8 warnings.
++ [[ 72 -gt 0 ]]
++ cat /sw/BUILD/90bedd9d2689b4e519c6f506a57e42264c76ca18/O2Physics-code-check/errors.txt
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:104:10: error: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:109:9: error: function-like macro 'getHist' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:110:28: error: macro argument should be enclosed in parentheses [bugprone-macro-parentheses,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:111:9: error: variadic macro 'fillHist' used; consider using a 'constexpr' variadic template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:116:9: error: variadic macro 'insertHist' used; consider using a 'constexpr' variadic template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:131:8: error: constructor does not initialize these fields: thisCascade, thisV0, pdgDB, ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:271:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:274:9: error: constructor does not initialize these fields: mcLabel, isDecayDau, isWeakDecayDau, isUsedInCascading, nSiliconHits, nTPCHits, trackType [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:299:5: error: function 'getTimeMUS' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:408:15: error: member 'timeResolutionNs' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:409:15: error: member 'nsToMus' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:410:15: error: member 'timeResolutionUs' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:434:27: error: use starts_with instead of find [modernize-use-starts-ends-with,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:707:26: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:715:5: error: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:759:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:761:53: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:769:56: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:789:36: error: the parameter 'particle' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:796:11: error: variable 'sna' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:796:16: error: variable 'csa' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:840:39: error: the parameter 'particle' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:893:90: error: the const qualified parameter 'histPath' is copied for each invocation; consider making it a reference [performance-unnecessary-value-param,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:954:5: error: uninitialized record type: 'isReco' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:955:5: error: uninitialized record type: 'nHitsCascadeProngs' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:956:5: error: uninitialized record type: 'nSiliconHitsCascadeProngs' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:957:5: error: uninitialized record type: 'nTPCHitsCascadeProngs' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:1045:9: error: do not use 'else' after 'continue' [readability-else-after-return,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:1100:9: error: uninitialized record type: 'pos' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:1101:9: error: uninitialized record type: 'posCascade' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:1102:9: error: uninitialized record type: 'posP' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:1103:9: error: uninitialized record type: 'negP' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:1104:9: error: uninitialized record type: 'bachP' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:1128:19: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:1222:15: error: uninitialized record type: 'posClusterCandidate' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:1240:15: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:1273:92: error: redundant boolean literal in ternary expression result [readability-simplify-boolean-expr,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:1275:9: error: uninitialized record type: 'pCasc' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:1276:9: error: uninitialized record type: 'pBach' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:1277:9: error: uninitialized record type: 'pV0' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:1333:11: error: redundant condition 'reconstructedCascade' [bugprone-redundant-branch-condition,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:1432:23: error: unused local variable 'histPath' of type 'const std::string' (aka 'const basic_string<char>') [bugprone-unused-local-non-trivial-variable,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

@jesgum
jesgum merged commit 5f7bbc9 into AliceO2Group:master Jul 24, 2026
11 of 14 checks passed
@jesgum
jesgum deleted the otf-tracker-dev01 branch July 24, 2026 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants