[PWGCF] Change nsigma TOF selections to optional cuts, force bit=1 when no TOF is found by allesgrau · Pull Request #17315 · AliceO2Group/O2Physics

allesgrau · 2026-08-04T12:26:02Z

No description provided.

…helors

Please consider the following formatting changes to AliceO2Group#17302

github-actions · 2026-08-04T12:26:21Z

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

ariedel-cern · 2026-08-04T13:07:50Z

      mOmegaMassUpperLimit = filter.rejectMassOmegaMax.value;
      this->addSelection(kBachelorTpcPion, cascadeSelectionNames.at(kBachelorTpcPion), config.bachelorTpcPion.value, limits::kAbsUpperLimit, true, true, false);
-      this->addSelection(kBachelorTofPion, cascadeSelectionNames.at(kBachelorTofPion), config.bachelorTofPion.value, limits::kAbsUpperLimit, true, true, false);
+      this->addSelection(kBachelorTofPion, cascadeSelectionNames.at(kBachelorTofPion), config.bachelorTofPion.value, limits::kAbsUpperLimit, true, false, false);


Here the flag should be set according to "requireTof" from the configuration

ariedel-cern · 2026-08-04T13:12:20Z

Hi @allesgrau ,
many thanks for the PR. I think the PR still needs some work. I commented here only the cascade builder, but the same comments apply also for the V0 builder.

…ask value to 0

Please consider the following formatting changes to AliceO2Group#17315

alibuild · 2026-08-04T21:35:25Z

Error while checking build/O2Physics/staging for 6a167d5 at 2026-08-04 23:35:

No log files found

Full log here.

alibuild · 2026-08-05T07:45:02Z

Error while checking build/O2Physics/code-check for 6a167d5 at 2026-08-05 09:45:

## sw/BUILD/O2-latest/log
CMake Error in Detectors/Base/CMakeLists.txt:

Full log here.

alibuild · 2026-08-05T08:32:20Z

Error while checking build/O2Physics/o2 for 6a167d5 at 2026-08-05 10:32:

## sw/BUILD/O2-latest/log
CMake Error in Detectors/Base/CMakeLists.txt:

Full log here.

…ion to be passed

alibuild · 2026-08-05T13:54:27Z

Error while checking build/O2Physics/staging for ffa39a6 at 2026-08-05 15:54:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/Femto/Core/v0Builder.h:355:32: error: 'kBachelorTofPion' was not declared in this scope; did you mean 'o2::analysis::femto::cascadebuilder::kBachelorTofPion'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/Femto/Core/v0Builder.h:355:32: error: 'kBachelorTofPion' was not declared in this scope
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/Femto/Core/v0Builder.h:355:32: error: 'kBachelorTofPion' was not declared in this scope
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/Femto/Core/v0Builder.h:355:32: error: 'kBachelorTofPion' was not declared in this scope
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/Femto/Core/v0Builder.h:355:32: error: 'kBachelorTofPion' was not declared in this scope
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/Femto/Core/v0Builder.h:355:32: error: 'kBachelorTofPion' was not declared in this scope
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/Femto/Core/v0Builder.h:355:32: error: 'kBachelorTofPion' was not declared in this scope
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/Femto/Core/v0Builder.h:355:32: error: 'kBachelorTofPion' was not declared in this scope; did you mean 'o2::analysis::femto::cascadebuilder::kBachelorTofPion'?
ninja: build stopped: subcommand failed.

Full log here.

alibuild · 2026-08-05T16:52:59Z

Error while checking build/O2Physics/code-check for a14e076 at 2026-08-05 18:52:

## sw/BUILD/O2Physics-latest/log
2026-08-05T17:59:06.639+0200 [22932:139872770854528] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Write()", last gRPC error was [14: Socket closed]
2026-08-05T17:59:06.732+0200 [22932:139872770854528] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.UpdateActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-08-05T17:59:08.720+0200 [23188:139885101260416] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-08-05T17:59:12.161+0200 [22985:139642967281280] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-08-05T17:59:17.300+0200 [23385:140469113855616] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-08-05T17:59:20.127+0200 [23015:139652293561984] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-08-05T17:59:21.804+0200 [23261:140683361394304] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-08-05T17:59:34.553+0200 [23084:140171770510976] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-08-05T17:59:38.077+0200 [23054:140008548888192] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-08-05T17:59:38.120+0200 [22910:139678691135104] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-08-05T17:59:16.066+0200 [24200:140558892674688] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-08-05T17:59:16.067+0200 [24200:140558892674688] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-08-05T17:59:14.597+0200 [24174:140083969777280] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-08-05T17:59:14.597+0200 [24174:140083969777280] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-08-05T17:59:25.625+0200 [24278:140050368798336] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-08-05T17:59:25.625+0200 [24278:140050368798336] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-08-05T17:59:37.006+0200 [24334:140099202150016] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-08-05T17:59:37.006+0200 [24334:140099202150016] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-08-05T17:59:19.465+0200 [24235:140046183059072] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-08-05T17:59:19.466+0200 [24235:140046183059072] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-08-05T17:59:25.835+0200 [24299:140063577828992] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-08-05T17:59:25.836+0200 [24299:140063577828992] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-08-05T17:59:08.775+0200 [24136:140533889457792] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-08-05T17:59:08.775+0200 [24136:140533889457792] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

allesgrau and others added 5 commits August 3, 2026 17:05

[PWGCF] Add TOF nsigma selection for V0 and cascade daughters and bac…

b28c6d9

…helors

Please consider the following formatting changes

70c0485

Merge pull request #2 from alibuild/alibot-cleanup-17302

75f27d2

Please consider the following formatting changes to AliceO2Group#17302

Merge branch 'AliceO2Group:master' into tof-selection-dau-bach

6c2c131

[PWGCF] Don't reject V0s with daughters that don't have TOF.

c9f4528

allesgrau requested review from alibuild, ariedel-cern, dimihayl, lauraser, shouqiye, victor-gonzalez and wrzesaCERN as code owners August 4, 2026 12:26

github-actions Bot added the pwgcf label Aug 4, 2026

linter fix: include <limits> where numeric_limits is used

0aa1c28

ariedel-cern reviewed Aug 4, 2026

View reviewed changes

Comment thread PWGCF/Femto/Core/cascadeBuilder.h Outdated

ariedel-cern reviewed Aug 4, 2026

View reviewed changes

Comment thread PWGCF/Femto/Core/cascadeBuilder.h Outdated

Comment thread PWGCF/Femto/Core/cascadeBuilder.h Outdated

allesgrau and others added 2 commits August 4, 2026 21:52

Add requireTof and keepTracksWithoutTof configurables, change setBitm…

3d37d83

…ask value to 0

Please consider the following formatting changes

b6343a7

alibuild mentioned this pull request Aug 4, 2026

Please consider the following formatting changes to #17315 allesgrau/O2Physics#3

Merged

Merge pull request #3 from alibuild/alibot-cleanup-17315

6a167d5

Please consider the following formatting changes to AliceO2Group#17315

ariedel-cern reviewed Aug 5, 2026

View reviewed changes

Comment thread PWGCF/Femto/Core/cascadeBuilder.h Outdated

ariedel-cern reviewed Aug 5, 2026

View reviewed changes

Comment thread PWGCF/Femto/Core/cascadeBuilder.h Outdated

ariedel-cern requested changes Aug 5, 2026

View reviewed changes

Merge branch 'AliceO2Group:master' into tof-selection-dau-bach

ea9ad1e

fix: EvaluateObservable instead of setBitmask in order for the select…

ffa39a6

…ion to be passed

fix: naming

a14e076

ariedel-cern approved these changes Aug 5, 2026

View reviewed changes

ariedel-cern enabled auto-merge (squash) August 5, 2026 14:27

ariedel-cern merged commit 4447aa5 into AliceO2Group:master Aug 5, 2026
14 of 15 checks passed

Navigation Menu

Uh oh!

[PWGCF] Change nsigma TOF selections to optional cuts, force bit=1 when no TOF is found - #17315

[PWGCF] Change nsigma TOF selections to optional cuts, force bit=1 when no TOF is found#17315
ariedel-cern merged 12 commits into
AliceO2Group:masterfrom
allesgrau:tof-selection-dau-bach

allesgrau commented Aug 4, 2026

Uh oh!

github-actions Bot commented Aug 4, 2026

Uh oh!

Uh oh!

ariedel-cern Aug 4, 2026

Uh oh!

Uh oh!

Uh oh!

ariedel-cern commented Aug 4, 2026

Uh oh!

alibuild commented Aug 4, 2026

Uh oh!

Uh oh!

Uh oh!

alibuild commented Aug 5, 2026

Uh oh!

alibuild commented Aug 5, 2026

Uh oh!

alibuild commented Aug 5, 2026

Uh oh!

Uh oh!

alibuild commented Aug 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

allesgrau commented Aug 4, 2026

Uh oh!

github-actions Bot commented Aug 4, 2026

Uh oh!

Uh oh!

ariedel-cern Aug 4, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ariedel-cern commented Aug 4, 2026

Uh oh!

alibuild commented Aug 4, 2026

Uh oh!

Uh oh!

Uh oh!

alibuild commented Aug 5, 2026

Uh oh!

alibuild commented Aug 5, 2026

Uh oh!

alibuild commented Aug 5, 2026

Uh oh!

Uh oh!

alibuild commented Aug 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants