Skip to content

[PWGLF] Preserve selected resonance parents during primary selection - #17328

Closed
sawankumawat wants to merge 7 commits into
AliceO2Group:masterfrom
sawankumawat:temp2
Closed

[PWGLF] Preserve selected resonance parents during primary selection#17328
sawankumawat wants to merge 7 commits into
AliceO2Group:masterfrom
sawankumawat:temp2

Conversation

@sawankumawat

Copy link
Copy Markdown
Contributor
  • preserve Phi, K*, Xi(1530), and Lambda(1520) when selectPrimaries is enabled
  • keep the existing primary selection for all other particles
  • add QA histograms before and after the primary selection for debugging the missing resonance parents

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 5 warnings, 🔕 0 disabled

@github-actions github-actions Bot added the pwglf label Aug 5, 2026
@github-actions github-actions Bot changed the title Preserve selected resonance parents during primary selection [PWGLF] Preserve selected resonance parents during primary selection Aug 5, 2026
@alibuild

alibuild commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 18deae5 at 2026-08-05 07:16:

## sw/BUILD/O2-latest/log
CMake Error in Detectors/Base/CMakeLists.txt:

Full log here.

@alibuild

alibuild commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 18deae5 at 2026-08-05 07:18:

## sw/BUILD/O2-latest/log
CMake Error in Detectors/Base/CMakeLists.txt:

Full log here.

@alibuild

alibuild commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 10da8ed at 2026-08-05 07:57:

## sw/BUILD/O2-latest/log
CMake Error in Detectors/Base/CMakeLists.txt:

Full log here.

@sawankumawat

Copy link
Copy Markdown
Contributor Author

@njacazio @romainschotter could you please review the pull request?

Thank you,
Sawan

@alibuild

alibuild commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 10da8ed at 2026-08-05 08:18:

## sw/BUILD/O2-latest/log
CMake Error in Detectors/Base/CMakeLists.txt:

Full log here.

@alibuild

alibuild commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 10da8ed at 2026-08-05 10:05:

## sw/BUILD/O2-latest/log
CMake Error in Detectors/Base/CMakeLists.txt:

Full log here.

@vkucera

vkucera commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

@njacazio @romainschotter could you please review the pull request?

Thank you, Sawan

Fix the errors first.

@sawankumawat

Copy link
Copy Markdown
Contributor Author

@njacazio @romainschotter could you please review the pull request?
Thank you, Sawan

Fix the errors first.

@njacazio @romainschotter could you please review the pull request?

Thank you, Sawan

Dear @njacazio @romainschotter all the checks are passed. could you please review the pull request and merge it.

Thank you

@romainschotter

Copy link
Copy Markdown
Collaborator

Hi @sawankumawat ! The PR looks fine. However, there is one thing I am not entirely sure to understand: what is the motivation for removing ZEM1, ZEM2, ZPA and ZPC?
Thank you very much!

@njacazio

njacazio commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

@sawankumawat

sawankumawat commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

Hi @sawankumawat ! The PR looks fine. However, there is one thing I am not entirely sure to understand: what is the motivation for removing ZEM1, ZEM2, ZPA and ZPC? Thank you very much!

Hi @romainschotter @njacazio ,
Thanks for reviewing the pull request. The reason I removed ZEM1, ZEM2, ZPA, and ZPC is that they were not being used in the further code, due to which Megalinter was showing an error. I will add it back as in the given pull request link.

@sawankumawat

Copy link
Copy Markdown
Contributor Author

For the ZEM and so on I would keep as in https://github.com/AliceO2Group/O2Physics/pull/17335/changes#diff-b72b569137758de173d971b952b8c7a0c475bb16e6b85d85753161aa570ecd27

Dear @njacazio @romainschotter I have commited the changes on top of your commit.

@romainschotter

Copy link
Copy Markdown
Collaborator

For the ZEM and so on I would keep as in https://github.com/AliceO2Group/O2Physics/pull/17335/changes#diff-b72b569137758de173d971b952b8c7a0c475bb16e6b85d85753161aa570ecd27

Dear @njacazio @romainschotter I have commited the changes on top of your commit.

Hi @sawankumawat ! Thanks a lot for the clarification and implementing the @njacazio changes!

@romainschotter
romainschotter enabled auto-merge (squash) August 5, 2026 18:06
@sawankumawat

Copy link
Copy Markdown
Contributor Author

For the ZEM and so on I would keep as in https://github.com/AliceO2Group/O2Physics/pull/17335/changes#diff-b72b569137758de173d971b952b8c7a0c475bb16e6b85d85753161aa570ecd27

Dear @njacazio @romainschotter I have commited the changes on top of your commit.

Hi @sawankumawat ! Thanks a lot for the clarification and implementing the @njacazio changes!

Thank you for approving.

@njacazio

njacazio commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Hi, this should be general github.com//pull/17335/ let me know if it's ok for you @sawankumawat

@njacazio
njacazio disabled auto-merge August 5, 2026 18:11
@romainschotter
romainschotter enabled auto-merge (squash) August 5, 2026 18:20
@alibuild

alibuild commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for bffe78e at 2026-08-06 04:45:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
c++: fatal error: Killed signal terminated program cc1plus
c++: fatal error: Killed signal terminated program cc1plus
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for d40cb79 at 2026-08-05 21:49:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 33 errors and 0 warnings.'
Found 33 errors and 0 warnings.
++ [[ 33 -gt 0 ]]
++ cat /sw/BUILD/d8d1fda8b2bd05cefb5f328b9ef7243c17f7a31e/O2Physics-code-check/errors.txt
PWGLF/Tasks/QC/mcParticlePrediction.cxx:60:14: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:61:1: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:61:6: error: variable 'enabledParticlesArray' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:97:26: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:125:1: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:125:6: error: variable 'enabledEstimatorsArray' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:126:14: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:144:59: error: variable 'hestimators' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:145:59: error: variable 'hestimatorsVsITS' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:146:59: error: variable 'hestimatorsVsETA05' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:147:59: error: variable 'hestimatorsVsETA08' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:148:59: error: variable 'hestimatorsVsImpactParameter' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:149:59: error: variable 'hestimatorsRecoEvGenVsReco' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:150:59: error: variable 'hestimatorsRecoEvGenVsReco_BCMC' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:151:59: error: variable 'hestimatorsRecoEvGenVsRecoITS' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:152:59: error: variable 'hestimatorsRecoEvRecoVsITS' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:153:59: error: variable 'hestimatorsRecoEvRecoVsRecoITS' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:154:59: error: variable 'hestimatorsRecoEvRecoVsRecoITS_BCMC' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:155:59: error: variable 'hestimatorsRecoEvRecoVsFT0A' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:156:59: error: variable 'hestimatorsRecoEvRecoVsBCId' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:157:59: error: variable 'hestimatorsRecoEvVsBCId' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:158:59: error: variable 'hvertexPosZ' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:159:93: error: variable 'hpt' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:160:93: error: variable 'hy' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:161:93: error: variable 'heta' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:162:93: error: variable 'hyield' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:164:8: error: constructor does not initialize these fields: pdgDB [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:194:51: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:197:54: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:446:5: error: uninitialized record type: 'nMult' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:752:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:764:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Utils/inelGt.h:117:11: error: using integer absolute value function 'abs' when argument is of floating point type [clang-diagnostic-absolute-value,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 33 -gt 0 ]]
++ exit 1
--

Full log here.

@sawankumawat

Copy link
Copy Markdown
Contributor Author

Hi, this should be general github.com//pull/17335/ let me know if it's ok for you @sawankumawat

Thanks for creating it. Yes it is fine with me.

auto-merge was automatically disabled August 6, 2026 08:28

Pull request was closed

@sawankumawat
sawankumawat deleted the temp2 branch August 6, 2026 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

5 participants