[PWGEM] PhotonMeson: Add faster V0 deduplication mode - #17336
Merged
Conversation
jokonig
commented
Aug 5, 2026
jokonig
commented
Collaborator
- current deduplication relies on nested for-loop of a map with 30000 elements. This makes computation slow
- New mode ranks all V0 candidates with a score, based on their cosPA and PCA
- V0s are accepted starting from V0s with the best score. A new V0 is only added if its daughter tracks have not yet been included in another V0 that has been accepted already
jokonig
requested review from
alibuild,
amaringarcia,
dsekihat,
hscheid,
mhemmer-cern and
reygers
as code owners
August 5, 2026 11:25
|
O2 linter results: ❌ 40 errors, |
jokonig
marked this pull request as draft
August 5, 2026 11:33
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
jokonig
marked this pull request as ready for review
August 5, 2026 11:41
jokonig
marked this pull request as draft
August 5, 2026 11:41
jokonig
marked this pull request as ready for review
August 5, 2026 11:48
mhemmer-cern
requested changes
Aug 5, 2026
mhemmer-cern
left a comment
mhemmer-cern
left a comment
Collaborator
There was a problem hiding this comment.
I think we can speed this up further plus reducing memory foot print by using std::vector instead of std::unordered_set
- current deduplication relies on nested for-loop of a map with 30000 elements. This makes computation slow - New mode ranks all V0 candidates with a score, based on their cosPA and PCA - V0s are accepted starting from V0s with the best score. A new V0 is only added if its daughter tracks have not yet been included in another V0 that has been accepted already
mhemmer-cern
enabled auto-merge (squash)
August 5, 2026 13:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.