Skip to content

[PWGJE] Fix includes - #17792

Merged
nzardosh merged 1 commit into
AliceO2Group:masterfrom
vkucera:iwyu-PWGJE
Sep 7, 2026
Merged

[PWGJE] Fix includes#17792
nzardosh merged 1 commit into
AliceO2Group:masterfrom
vkucera:iwyu-PWGJE

Conversation

@vkucera

@vkucera vkucera commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions github-actions Bot added the pwgje label Sep 5, 2026
@github-actions github-actions Bot changed the title Fix includes [PWGJE] Fix includes Sep 5, 2026
@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 77 errors, ⚠️ 53 warnings, 🔕 2 disabled

@alibuild

alibuild commented Sep 6, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 2cbb298 at 2026-09-06 21:07:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 8 errors and 35 warnings.'
Found 8 errors and 35 warnings.
++ [[ 8 -gt 0 ]]
++ cat /sw/BUILD/07d5f8fe9fa182956d0f7b336f892dc41124a711/O2Physics-code-check/errors.txt
PWGJE/TableProducer/berkeleyTreeProducer.cxx:87:8: error: constructor does not initialize these fields: pdg [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGJE/TableProducer/derivedDataWriter.cxx:52:8: error: constructor does not initialize these fields: precisionPositionMask, precisionMomentumMask [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGJE/TableProducer/derivedDataWriter.cxx:716:19: error: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy,-warnings-as-errors]
PWGJE/TableProducer/derivedDataWriter.cxx:720:19: error: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy,-warnings-as-errors]
PWGJE/Tasks/jetBackgroundAnalysis.cxx:48:8: error: constructor does not initialize these fields: pdgDatabase [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGJE/Tasks/jetHFAngularity.cxx:498:14: error: variable 'm' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGJE/Tasks/trackEfficiency.cxx:48:8: error: constructor does not initialize these fields: pdg [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGJE/Tasks/trackEfficiency.cxx:177:139: error: the parameter 'tracks' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
++ [[ 35 -gt 0 ]]
++ cat /sw/BUILD/07d5f8fe9fa182956d0f7b336f892dc41124a711/O2Physics-code-check/warnings.txt
PWGJE/TableProducer/berkeleyTreeProducer.cxx:139:124: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/TableProducer/berkeleyTreeProducer.cxx:141:49: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/TableProducer/berkeleyTreeProducer.cxx:156:72: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/TableProducer/berkeleyTreeProducer.cxx:159:46: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/TableProducer/berkeleyTreeProducer.cxx:161:33: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/TableProducer/berkeleyTreeProducer.cxx:168:34: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/TableProducer/berkeleyTreeProducer.cxx:170:11: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/TableProducer/berkeleyTreeProducer.cxx:180:36: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/TableProducer/berkeleyTreeProducer.cxx:182:44: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/TableProducer/berkeleyTreeProducer.cxx:184:31: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/TableProducer/berkeleyTreeProducer.cxx:186:45: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/TableProducer/derivedDataWriter.cxx:723:11: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGJE/TableProducer/derivedDataWriter.cxx:943:9: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGJE/Tasks/bjetTreeCreator.cxx:52:10: warning: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers]
PWGJE/Tasks/jetBackgroundAnalysis.cxx:42:10: warning: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers]
PWGJE/Tasks/jetBackgroundAnalysis.cxx:77:24: warning: initializer for member 'randomNumber' is redundant [readability-redundant-member-init]
PWGJE/Tasks/jetBackgroundAnalysis.cxx:146:77: warning: redundant explicit casting to the same type 'float' as the sub-expression, remove this casting [readability-redundant-casting]
PWGJE/Tasks/jetBackgroundAnalysis.cxx:159:119: warning: redundant explicit casting to the same type 'float' as the sub-expression, remove this casting [readability-redundant-casting]
PWGJE/Tasks/jetBackgroundAnalysis.cxx:173:98: warning: redundant explicit casting to the same type 'float' as the sub-expression, remove this casting [readability-redundant-casting]
PWGJE/Tasks/jetBackgroundAnalysis.cxx:181:94: warning: redundant explicit casting to the same type 'float' as the sub-expression, remove this casting [readability-redundant-casting]
PWGJE/Tasks/jetBackgroundAnalysis.cxx:188:81: warning: redundant explicit casting to the same type 'float' as the sub-expression, remove this casting [readability-redundant-casting]
PWGJE/Tasks/jetBackgroundAnalysis.cxx:207:121: warning: redundant explicit casting to the same type 'float' as the sub-expression, remove this casting [readability-redundant-casting]
PWGJE/Tasks/jetBackgroundAnalysis.cxx:233:75: warning: redundant explicit casting to the same type 'float' as the sub-expression, remove this casting [readability-redundant-casting]
PWGJE/Tasks/jetBackgroundAnalysis.cxx:244:117: warning: redundant explicit casting to the same type 'float' as the sub-expression, remove this casting [readability-redundant-casting]
PWGJE/Tasks/jetBackgroundAnalysis.cxx:257:98: warning: redundant explicit casting to the same type 'float' as the sub-expression, remove this casting [readability-redundant-casting]
PWGJE/Tasks/jetBackgroundAnalysis.cxx:265:94: warning: redundant explicit casting to the same type 'float' as the sub-expression, remove this casting [readability-redundant-casting]
PWGJE/Tasks/jetBackgroundAnalysis.cxx:271:79: warning: redundant explicit casting to the same type 'float' as the sub-expression, remove this casting [readability-redundant-casting]
PWGJE/Tasks/jetBackgroundAnalysis.cxx:288:119: warning: redundant explicit casting to the same type 'float' as the sub-expression, remove this casting [readability-redundant-casting]
PWGJE/Tasks/jetHFAngularity.cxx:859:13: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGJE/Tasks/jetHFAngularity.cxx:860:13: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGJE/Tasks/jetHFAngularity.cxx:861:13: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGJE/Tasks/jetOutlierQA.cxx:40:10: warning: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers]
[0 more errors; see full log]

Full log here.

@nzardosh
nzardosh merged commit 94c99d7 into AliceO2Group:master Sep 7, 2026
11 of 14 checks passed
@vkucera
vkucera deleted the iwyu-PWGJE branch September 7, 2026 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants