Skip to content

[PWGHF] Adding D0/Lc analysis task - #17808

Open
laszlogyulai wants to merge 8 commits into
AliceO2Group:masterfrom
laszlogyulai:master
Open

[PWGHF] Adding D0/Lc analysis task#17808
laszlogyulai wants to merge 8 commits into
AliceO2Group:masterfrom
laszlogyulai:master

Conversation

@laszlogyulai

Copy link
Copy Markdown

Adding a new analysis task for calculating the D0/Lambda_c yield ratio as a function of flattenicity

@github-actions github-actions Bot added the pwghf PWG-HF label Sep 7, 2026
@github-actions github-actions Bot changed the title Adding D0/Lc analysis task [PWGHF] Adding D0/Lc analysis task Sep 7, 2026
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 40 errors, ⚠️ 6 warnings, 🔕 0 disabled

@laszlogyulai

Copy link
Copy Markdown
Author

Dear codeowners,

Is it possible to overcome the "magic number" errors in the O2 linter / O2 linter (pull_request_target) check? In my opinion it would unnecessarily complicate the existing code. You can see an example of such a solution in the PWGLF/Tasks/GlobalEventProperties/flattenicityPikp.cxx file (lines 1814-1908)

@vkucera

vkucera commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

Dear codeowners,

Is it possible to overcome the "magic number" errors in the O2 linter / O2 linter (pull_request_target) check? In my opinion it would unnecessarily complicate the existing code. You can see an example of such a solution in the PWGLF/Tasks/GlobalEventProperties/flattenicityPikp.cxx file (lines 1814-1908)

The way to "overcome" it is to write it in a better way. From what I can see, you map some number to other numbers. So how about using a map or an array, for example?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pwghf PWG-HF

Development

Successfully merging this pull request may close these issues.

3 participants