Skip to content

[PWGDQ] added derived tables to global muon alignment task - #17809

Merged
mguilbau merged 1 commit into
AliceO2Group:masterfrom
aferrero2707:PWGDQ-global-alignment-add-derived-tables
Sep 8, 2026
Merged

[PWGDQ] added derived tables to global muon alignment task#17809
mguilbau merged 1 commit into
AliceO2Group:masterfrom
aferrero2707:PWGDQ-global-alignment-add-derived-tables

Conversation

@aferrero2707

Copy link
Copy Markdown
Contributor

The derived tables provide the minimal information neederd to run the alignment analysis on new geometries, thus avoiding to pocess each time the original large-size AO2Ds.

A pre-processor switch allows to use the same task for either producing or processing the derived tables.

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 69 warnings, 🔕 9 disabled

@aferrero2707

Copy link
Copy Markdown
Contributor Author

@mcoquet642 @javierecc @ppoava here is another relatively urgent PR, that should allow to iterate over the alignment geometries much faster with small derived tables.

I still need to rebase once #17743 is merged, but you can already have a look at the changes if you have the time.

Thanks!

@aferrero2707
aferrero2707 force-pushed the PWGDQ-global-alignment-add-derived-tables branch from df4241e to 33c405e Compare September 8, 2026 06:07
@aferrero2707
aferrero2707 marked this pull request as ready for review September 8, 2026 06:18
@aferrero2707
aferrero2707 marked this pull request as draft September 8, 2026 07:58
The derived tables provide the minimal information neederd to run the
alignment analysis on new geometries, thus avoiding to pocess each time
the original large-size AO2Ds.

A pre-processor switch allows to use the same task for either producing
or processing the derived tables.
@aferrero2707
aferrero2707 force-pushed the PWGDQ-global-alignment-add-derived-tables branch from 33c405e to 0d8bcd8 Compare September 8, 2026 08:05
@aferrero2707
aferrero2707 marked this pull request as ready for review September 8, 2026 08:19
@mguilbau

mguilbau commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

@mcoquet642 I looked at the changes. This look fine to me but I believe it is better if you take a quick look before merging

@aferrero2707

aferrero2707 commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

@mcoquet642 @mguilbau note that the changes only affect the task we use for the in-depth analysis of the global muon alignment, and do not touch other parts of the DQ code.

Unless there are serious errors reported by the code-check, it should be good to go.

@mguilbau

mguilbau commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

No serious error reported indeed. I will approve it then

@mguilbau
mguilbau merged commit 54ad18c into AliceO2Group:master Sep 8, 2026
12 of 14 checks passed
@alibuild

alibuild commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 0d8bcd8 at 2026-09-08 12:04:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 1 errors and 0 warnings.'
Found 1 errors and 0 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/bc08792a8dd47ac299e2b883149a1d6f30d511ab/O2Physics-code-check/errors.txt
PWGDQ/Tasks/muonGlobalAlignment.cxx:239:9: error: macro 'PROCESS_DERIVED_TABLES' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 1 -gt 0 ]]
++ exit 1
--

Full log here.

@mcoquet642

Copy link
Copy Markdown
Collaborator

@mguilbau In future please wait for the code-check to finish before merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants