Skip to content

[PWGJE] bjetTaggingGnn.cxx: Revised histogram fill code #17824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nzardosh merged 1 commit into from
Sep 9, 2026
+32 −4
Merged

[PWGJE] bjetTaggingGnn.cxx: Revised histogram fill code #17824

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 32 additions & 4 deletions PWGJE/Tasks/bjetTaggingGnn.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
/// \file bjetTaggingGnn.cxx
/// \brief b-jet tagging using GNN
///
/// \author Changhwan Choi <changhwan.choi@cern.ch>, Pusan National University
/// \author Changhwan Choi <changhwan.choi@cern.ch>, Yonsei University

#include "PWGJE/Core/JetDerivedDataUtilities.h"
#include "PWGJE/Core/JetTaggingUtilities.h"
Expand Down Expand Up @@ -197,8 +197,12 @@ struct BjetTaggingGnn {
Configurable<float> trackNppCrit{"trackNppCrit", 0.95, "track not physical primary ratio"};

// jet level configurables
Configurable<int> jetPtNbins{"jetPtNbins", 300, "number of bins for jet pT"};
Configurable<float> jetPtMin{"jetPtMin", 0.0, "minimum jet pT"};
Configurable<float> jetPtMax{"jetPtMax", 1000.0, "maximum jet pT"};
Configurable<float> jetPtMax{"jetPtMax", 300.0, "maximum jet pT"};
Configurable<int> jetPtSubNbins{"jetPtSubNbins", 300, "number of bins for UE-subtracted jet pT"};
Configurable<float> jetPtSubMin{"jetPtSubMin", -50.0, "minimum UE-subtracted jet pT"};
Configurable<float> jetPtSubMax{"jetPtSubMax", 250.0, "maximum UE-subtracted jet pT"};
Configurable<float> jetEtaMin{"jetEtaMin", -0.9, "minimum jet pseudorapidity"};
Configurable<float> jetEtaMax{"jetEtaMax", 0.9, "maximum jet pseudorapidity"};
Configurable<float> leadingConstituentPtMin{"leadingConstituentPtMin", -99.0, "minimum pT selection on jet constituent"};
Expand Down Expand Up @@ -331,9 +335,9 @@ struct BjetTaggingGnn {

const AxisSpec axisTrackpT{200, 0., 200., "#it{p}_{T} (GeV/#it{c})"};
const AxisSpec axisTrackpTFine{1000, 0., 10., "#it{p}_{T} (GeV/#it{c})"};
const AxisSpec axisJetpT{250, 0., 250., "#it{p}_{T, ch jet} (GeV/#it{c})"};
const AxisSpec axisJetpT{jetPtNbins, jetPtMin, jetPtMax, "#it{p}_{T, ch jet} (GeV/#it{c})"};
// Used in place of axisJetpT for every "_sub"-suffixed histogram (UE-subtracted jet pT can go negative).
const AxisSpec axisJetpTSub{300, -50., 250., "#it{p}_{T, ch jet}^{sub} (GeV/#it{c})"};
const AxisSpec axisJetpTSub{jetPtSubNbins, jetPtSubMin, jetPtSubMax, "#it{p}_{T, ch jet}^{sub} (GeV/#it{c})"};
const AxisSpec axisJetEta{200, -0.8, 0.8, "#it{#eta}_{jet}"};
const AxisSpec axisDb{200, dbMin, dbMax, "#it{D}_{b}"};
const AxisSpec axisDbFine{dbNbins, dbMin, dbMax, "#it{D}_{b}"};
Expand Down Expand Up @@ -1135,8 +1139,32 @@ struct BjetTaggingGnn {
if (doDataDriven && doDataDrivenSV) {
if constexpr (withSub) {
registry.fill(HIST("hSparse_Incljets_sub"), jetpT, analysisJet.scoreML(), nTracks, massSV, weightEvt);
if (jetFlavor == JetTaggingSpecies::beauty) {
registry.fill(HIST("hSparse_bjets_sub"), jetpT, analysisJet.scoreML(), nTracks, massSV, weightEvt);
} else if (jetFlavor == JetTaggingSpecies::charm) {
registry.fill(HIST("hSparse_cjets_sub"), jetpT, analysisJet.scoreML(), nTracks, massSV, weightEvt);

@nzardosh nzardosh Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

none of the histograms with _sub have been added to the histogram registry

@choich08365 choich08365 Sep 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Nima, thanks for your comment. By the way, the function addDataDrivenHistograms in line 634 does add those histograms to the registry properly. The local test runs okay.

} else {
registry.fill(HIST("hSparse_lfjets_sub"), jetpT, analysisJet.scoreML(), nTracks, massSV, weightEvt);
if (jetFlavor == JetTaggingSpecies::none) {
registry.fill(HIST("hSparse_lfjets_none_sub"), jetpT, analysisJet.scoreML(), nTracks, massSV, weightEvt);
} else {
registry.fill(HIST("hSparse_lfjets_matched_sub"), jetpT, analysisJet.scoreML(), nTracks, massSV, weightEvt);
}
}
} else {
registry.fill(HIST("hSparse_Incljets"), jetpT, analysisJet.scoreML(), nTracks, massSV, weightEvt);
if (jetFlavor == JetTaggingSpecies::beauty) {
registry.fill(HIST("hSparse_bjets"), jetpT, analysisJet.scoreML(), nTracks, massSV, weightEvt);
} else if (jetFlavor == JetTaggingSpecies::charm) {
registry.fill(HIST("hSparse_cjets"), jetpT, analysisJet.scoreML(), nTracks, massSV, weightEvt);
} else {
registry.fill(HIST("hSparse_lfjets"), jetpT, analysisJet.scoreML(), nTracks, massSV, weightEvt);
if (jetFlavor == JetTaggingSpecies::none) {
registry.fill(HIST("hSparse_lfjets_none"), jetpT, analysisJet.scoreML(), nTracks, massSV, weightEvt);
} else {
registry.fill(HIST("hSparse_lfjets_matched"), jetpT, analysisJet.scoreML(), nTracks, massSV, weightEvt);
}
}
}
}

Expand Down
Loading