Repository navigation
Conversation
…d dqEfficiency_withAssoc.
|
O2 linter results: ❌ 0 errors, |
axti98
marked this pull request as ready for review
October 27, 2026 17:54
axti98
requested review from
XiaozhiBai,
alibuild,
glegras,
iarsene,
lucamicheletti93,
mguilbau and
shreyasiacharya
as code owners
October 27, 2026 17:54
Collaborator
Author
|
@mguilbau @XiaozhiBai @shreyasiacharya @glegras @iarsene I have tested now and it should work as intended. I have just one remark which me might need to discuss. In MC, the reconstructed collisions are rejected if a corresponding flag is set, but the MC Truth collision is kept. This is the same behaviour as in the TableMaker(MC). This has for itself no problems, but silently is entering the definition of efficiencies. For now, we take bad detector conditions with the RCT flag as "Efficiency Loss", the true collision stays, but the reconstructed one is removed. The question is whether this definition is intended like this or if also the MC Collisions should be handled. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For now, the run condition table (RCT) flags could only be set during skimming. To avoid new skimmings, fetch RCT information from CCDB per run and do the rejection for the skimmed tasks.