Repository navigation
[WIP] [QC-353] External tasks' detector - #2702
Open
Barthelemy wants to merge 1 commit into
Open
Barthelemy wants to merge 1 commit into
Barthelemy wants to merge 1 commit into
Conversation
We introduce a new parameter in the configuration of the external tasks: `detectorName`. Until now we used the query origin as heuristic. It works but it introduces a number of changes that are not all very satisfactory IMO. In particular, we have to maintain a map with the external task detector names in the CheckRunner because the information is only present in the config and not in the received objects like for the normal MOs.
Collaborator
Author
|
@knopers8 What do you think ? did I miss a simpler way of achieving the same ? is it worth it ? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We introduce a new parameter in the configuration of the external tasks:
detectorName. Until now we used the query origin as heuristic.It works but it introduces a number of changes that are not all very satisfactory IMO. In particular, we have to maintain a map with the external task detector names in the CheckRunner because the information is only present in the config and not in the received objects like for the normal MOs.