refactor: update reward size references - #51
Merged
Conversation
arjunsridhar12345
marked this pull request as ready for review
July 25, 2026 00:22
micahwoodard
approved these changes
Jul 27, 2026
| reward_size_right: float = Field( | ||
| reward_size_right: Optional[float] = Field( | ||
| default=None, | ||
| description="The reward volume (uL) delivered at the right lick port if rewarded.", |
There was a problem hiding this comment.
Why are these optional now? Is the logic if no reward, reward_size = None?
Collaborator
Author
There was a problem hiding this comment.
I think those were unnecessary guard checks for None. Removed them in 491805b
|
@arjunsridhar12345 is it safe to deploy the update acquisition code on rigs or do other things need to be updated? |
Collaborator
Author
|
I think we have to do another release of the pipeline in code ocean first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempts to close #30. Tries to update the reward size reference and minor updates from using the latest commit of the acquisition repo