Repository navigation
Conversation
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 39489504 | Triggered | Generic Password | a6294c3 | .agents/skills/verify-dms-api/journeys/capture.mjs | View secret |
| 39538590 | Triggered | Generic Password | bab6d92 | .agents/skills/verify-dms-api/journeys/capture.mjs | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
…t, the Tester exclusion and the comparison horizon
…the module header; cite the filed issues
…labels, per-block refusals and the 120-bar journey
…rization, the hero clock, the compared figures and the replay
… rank by average, filter by handler, the public origin and the drawer position
…handler, public origin, folders and the drawer position
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Antony wants every Clean AntelopeJS repo to carry its V5 verification skill on campaign/integration. This adds
.agents/skills/verify-dms-api, driven by thedms-controlbin of@antelopejs/dms, for the API console (health verdict, request logs, routes, tester, settings, retention). No product code changes.What changed
.agents/skills/verify-dms-api/: SKILL.md,verify.config.ts(doors block), a playground (the module from the checkout, a fixture module serving/fx/*routes, a member route), 11 features, 53 journeys, onecoverage/table per feature (every documented behaviour pinned by an asserting check, or a Not driven row with its reason), 11 seeded breaks, 6 seeded doors.AGENTS.mdgets the lineantelopejs-syncwrites once a verify skill exists..gitignoreignores the skill's build output, un-ignores itscoverage/folder (the repo ignorescoverage), and the line that lost its newline in round 1 is repaired.playground/node_modulessymlink is gone (the prepare step recreates it).Round 2 (verifier round 1 at d53f243: FAIL, new breaks n1 to n4 MISSED)
/modules/apiredirect,proxy-authorizationand the other credential headers refused.fromTester(log) || true) is an equivalent mutant: the contract queries already passapiTrafficOnly, which drops every request that has a source, so thefromTesterfilters are dead code. The same patch plusapiTrafficOnly: false(n4b) is CAUGHT.?since=&until=link, the confirmation before lowering a retention.Proofs (head
f0f6637a562dda5146eae863b3733add68c8f2e4)up --prepare, TZ=UTC): 53 journeys, 51 PASS, 2 FAIL (the two proven findings below). Two journeys needed a count fixed after I added a fixture route and passed on a rerun; the settings and retention features were rerun on the final split.seeded, one run per feature, each started below load 32: 11 of 11 CAUGHT (smoke, capture, overview, logs, routes, tester, settings, retention, access, package, automation).sincebound ignored), o4 (retention impact rounds down): 4 of 4 CAUGHT; round 1's 7 own breaks stay CAUGHT.dms-control doors: all 6 kinds named.dms-control map: clean.antelopejs-sync --check: in sync.GITHUB_BASE_REF=campaign/integration pnpm run checks:Checks: 8 passed, 0 failed.The suppression budget is unchanged. api-diff cannot run (the@/alias breaks its emit); hand proof: the diff against campaign/integration lists only.agents/skills/verify-dms-api/**,AGENTS.mdand.gitignore.625e0db,--min-catch 1.0 --min-door-catch 1.0 --jobs 3, claude-sonnet-5-5,TZ=UTCandDMS_CONTROL_MONGODpassed): breaks 10 of 11 then 11 of 11 (the single miss,break-capture, was a verifier that stopped before its journeys ran; rerun alone: caught), doors 6/6, unpatched head PASS+NOTES, $1.88 over 19 cases. The command exits 1 only because the harness reports leftover processes in three cases, which I killed by PID.TZ=UTC; SKILL.md says so.Rounds 3 and 4 (verifier FAIL at f0f6637: m2; at 6821f41: p5)
a-past-range-draws-at-most-120-barsFAILS on purpose (121 bars for two ranges; issue draftdms-api-past-range-121-bars, to be filed). The histogram journey keeps the exact bar lengths and a lower bound only.2dba88a(n4 is an equivalent mutant, accepted; n4b CAUGHT). The full gate set (battery, all seeded, doors, eval, checks) is still to run once, after the owner's own breaks.Findings
@antelopejs/apibuildsprotohandlers, the module readscontroller(the skill patches a copy of the package).settings/a-log-retention-of-no-day-is-refused-at-start):requestLogRetention: 0starts the module.access/a-role-opens-the-blocks-it-holds-and-no-others): per-block role permissions are never granted.x-dms-api-source, the code sendsx-antelopejs-api-source(docs mismatch; draft pending filing, pinned in coverage/tester.md).Attention
secretatjourneys/capture.mjs:161(key names, not credentials). It is renamed at this head. Older commits keep the string and I do not force-push, so the incident needs a dashboard false-positive mark. The squash merge drops it.L,/,?, pointer drag, a typed Authorization header replacing the session, History restore, the Tester's query and body editors, multi-instance secret sharing.--requireshim (clock.cjs).up --prepareneeds the npm registry once; it was retried when a just-published dependency 404ed.