Repository navigation
Conversation
…d contain the format door
…ix the validation break
…laration throws and option precedence
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Antony wants every Clean AntelopeJS repo to carry its verification skill, so a change to interface-data-api is proven by driving the routes it generates, not only by its unit tests. This draft adds the
verify-interfaceskill, built like the other V5 interface repos, tocampaign/integration.What changed
antelopejs-sync --verify interface, pack 0.2.17, no bump):SKILL.md,package.json,tsconfig.json, the.claude/skillslink and one line inAGENTS.md.sync --checkis clean..agents/skills/verify-interface/:features/: 13 features (12 plussmoke), each withcovers:,docs:and journeys, and a "Not driven" table with an honest reason per documented behaviour no journey reaches.verify.config.ts,journeys-*.ts,harness.ts,seeds.ts: the journeys. Each compilesfixture/shop.ts.txt(a consumer module written from the docs) against the packed declarations, startsajs project devwith@antelopejs/apiand@antelopejs/mongodbagainst a Docker MongoDB (mongo:7), drives the routes with curl and reads every write back withmongosh.seeded-breaks/(13) andseeded-doors/(5).Known issues, driven on purpose
Three journeys fail on head and cite their issue, so a verdict that runs their feature is FAIL until the issue is fixed:
issue-90-edit-index(#90),issue-92-getter-mode(#92) andissue-93-multi-foreign(#93). A diff that touches no mapped feature, like this one, runs onlysmokeand passes.Proof
Counts are copied from the bins' output (logs in
~/.cache/campaign2/v5/interface-data-api/tmp/proof/). The full set ran at the head named in the last row of this section; earlier heads ran the breaks listed under each round.antelopejs-verify mapdoctorseededseeded-doorscontainmentscrud/crud-lifecycle,validation/mandatory-and-validators)new,doctor, every journey,verdict,clean)clean(2889 files)--min-catch 1.0 --min-door-catch 1.0 --jobs 3pnpm run checkswithGITHUB_BASE_REF=campaign/integrationExtra breaks (not in the seeded set)
FilterValuesOf, mandatory skipped on edit validators, edit response foreign, bigint row, modifier lockfalse, guardthis,new_id, indexed filters, filterthis, class defaults, setters)noForeign: "false"), NB3 to NB5Attention
indexoption updates the row whose primary key equalsid#90, fix(list): a getter declared listable in the default mode is evaluated in other list modes #92 and fix(foreign): a multi reference answers{}for a missing element and character-index objects withnoForeign#93 (above). Fixing the product turns each journey green.Query.Listcomposition helpers and index-use of equality filters, because only the query plan differs.seeded accessfailed once withFailed to construct modules(MongoDB took more than 30 s to answer under load from a concurrent eval). A patched run cannot count, so the harness reported MISSED; the rerun is in the next body update.pnpm run checksrun on this repository compares suppressions againstmainunlessGITHUB_BASE_REF=campaign/integrationis set. With it set, the suppression step is clean.@antelopejs/interface-*range, pack version or tarball changed.