Repository navigation
Native: register the Backup type and test BACKUP DATABASE on both wheels; docs: open a database with an older wheel - #416
Merged
Conversation
…est the statement on both wheels Upstream ArcadeData/arcadedb#12556 (fcc52e0f) registered com.arcadedb.integration.backup.Backup in its own reachability metadata: the (Database, String) constructor and backupDatabase(). BACKUP DATABASE finds the class by name; since #12412 (after the 26.11.1 release) it looks the method up inside a lambda, which native-image cannot fold, so the nightly native build lost the method (NoSuchMethodException). This file had no entry. The entry is copied as upstream has it (same type, same two methods, no flags), in this file's one-space indent and alphabetical place. At the pinned engine 26.11.1 the lookup is not yet in a lambda, so the entry is not needed there; it is needed from the first engine release that contains #12412, and it does no harm before. The only BACKUP DATABASE test is JVM-only because it sets the engine's global backup directory through JPype. The new test starts a server (the default backup directory is <root path>/backups, so nothing global is set), runs BACKUP DATABASE, finds the archive, unzips it and opens it, so it runs on the native wheel too. Not run here: no tests could be run on the authoring host. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
26.11.1 wheels write float and double arrays in the fixed-width form (binary types 36 and 37, arcadedb.serializer.fixedWidthFloatArrays, on by default). Read from upstream: the setting's default and text at 26.11.1, ArcadeData/arcadedb#12234 (26.10.x and 26.9.1 open such a database without an error, read the arrays as null, and the next UPDATE drops them) and #12239 (fd18fce4, main only: the dictionary is labelled format version 2 while the setting is on, at the first read-write open, and builds from 26.8.1 to 26.11.x refuse it; setting it to false before that open keeps a rollback possible). The page has no upgrade or downgrade section, so a new one goes on the installation page, with the safe rule and the system property route that the durability page already documents. No static release-notes file exists: the release notes are built from pull request titles (scripts/release_notes.py). Not run: the Antora build (the Docs workflow does it). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Two changes that follow upstream ArcadeData/arcadedb, one commit each.
com.arcadedb.integration.backup.Backupto the native reachability metadata (the(Database, String)constructor andbackupDatabase()), as upstream fix(native): BACKUP DATABASE keeps Backup.backupDatabase() in the native image arcadedb#12556 (fcc52e0f) has it, and addstest_backup_database_runs_through_a_server_on_both_wheels, which runsBACKUP DATABASEon the native wheel too. The existing JVM-only test is unchanged.docs/modules/ROOT/pages/installation.adoc: 26.11.x wheels write fixed-width float arrays, older wheels read them asnulland the nextUPDATEdrops them (Rollback after an upgrade: 26.10.x and 26.9.1 open a database holding float arrays written by 26.11.1 or later, read them as null, and the first UPDATE of such a record erases them (no refusal at open) arcadedb#12234), and a later engine labels the dictionary so that older builds refuse the database (fix(#12234): label the dictionary of a database that writes fixed-width float arrays, so an older build refuses it instead of losing arrays arcadedb#12239). The safe rule is to keep a backup and not open such a database with a 26.10.x or older wheel.At the pinned engine 26.11.1 the metadata entry is not yet needed (the
getMethodlookup is not in a lambda there). It is needed from the first engine release that contains ArcadeData/arcadedb#12412, so with the next engine bump.Related issues
Fixes #414
Fixes #415
Docs
docs/modules/ROOT/pages/installation.adochas the new section. No static release-notes file exists (release notes are built from pull request titles byscripts/release_notes.py), so there is nothing else to update.README.mddoes not describe either change.How it is verified
I could not run any test, build the native image or build the docs site where I wrote this, so none of the following has run yet.
test_backup_database_runs_through_a_server_on_both_wheelson the native wheeltest-native.yml, "Run the parity suite" (shared tests run on the native wheel)test-jvm.yml(Test arcadedb (<platform>, Python <version>))test-native.yml, build job (a wrong entry would fail the build or the new test)docs.ymlpre-commitjob; I rancompile(), pyflakes, black 26.10.1, isort and ruff 0.17.4 on the test file, andjson.loadon the metadata fileThe part of the new test I am least sure of: it expects the server's backup directory to be
<root path>/backups(the default), and looks forperson.zipanywhere under the server root.Checklist
BACKUP DATABASEtestuvx pre-commit run --files <changed files>passes: not run (needs Docker)