Skip to content

Native: register the Backup type and test BACKUP DATABASE on both wheels; docs: open a database with an older wheel - #416

Merged
tae898 merged 2 commits into
mainfrom
fix/native-backup-metadata-and-float-array-note
Nov 20, 2026
Merged

tae898 merged 2 commits into
mainfrom
fix/native-backup-metadata-and-float-array-note

Conversation

@tae898

@tae898 tae898 commented Nov 20, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

Two changes that follow upstream ArcadeData/arcadedb, one commit each.

At the pinned engine 26.11.1 the metadata entry is not yet needed (the getMethod lookup is not in a lambda there). It is needed from the first engine release that contains ArcadeData/arcadedb#12412, so with the next engine bump.

Related issues

Fixes #414

Fixes #415

Docs

docs/modules/ROOT/pages/installation.adoc has the new section. No static release-notes file exists (release notes are built from pull request titles by scripts/release_notes.py), so there is nothing else to update. README.md does not describe either change.

How it is verified

I could not run any test, build the native image or build the docs site where I wrote this, so none of the following has run yet.

Check Job that runs it
test_backup_database_runs_through_a_server_on_both_wheels on the native wheel test-native.yml, "Run the parity suite" (shared tests run on the native wheel)
the same test on the JVM wheel test-jvm.yml (Test arcadedb (<platform>, Python <version>))
the native image still builds with the new metadata entry test-native.yml, build job (a wrong entry would fail the build or the new test)
the new AsciiDoc section builds without a warning docs.yml
JSON still parses, formatting hooks pre-commit job; I ran compile(), pyflakes, black 26.10.1, isort and ruff 0.17.4 on the test file, and json.load on the metadata file

The part of the new test I am least sure of: it expects the server's backup directory to be <root path>/backups (the default), and looks for person.zip anywhere under the server root.

Checklist

  • A regression test fails on the old code and passes on the new: the new test cannot fail on 26.11.1 (the lookup is not in a lambda there), so it guards the next engine bump, and it gives the native wheel its first BACKUP DATABASE test
  • The test suite that the change can affect passes: not run yet, see above
  • uvx pre-commit run --files <changed files> passes: not run (needs Docker)

tae898 and others added 2 commits November 20, 2026 13:27
…est the statement on both wheels

Upstream ArcadeData/arcadedb#12556 (fcc52e0f) registered
com.arcadedb.integration.backup.Backup in its own reachability metadata:
the (Database, String) constructor and backupDatabase(). BACKUP DATABASE
finds the class by name; since #12412 (after the 26.11.1 release) it looks the
method up inside a lambda, which native-image cannot fold, so the nightly
native build lost the method (NoSuchMethodException). This file had no entry.

The entry is copied as upstream has it (same type, same two methods, no
flags), in this file's one-space indent and alphabetical place. At the pinned
engine 26.11.1 the lookup is not yet in a lambda, so the entry is not
needed there; it is needed from the first engine release that contains
#12412, and it does no harm before.

The only BACKUP DATABASE test is JVM-only because it sets the engine's
global backup directory through JPype. The new test starts a server (the
default backup directory is <root path>/backups, so nothing global is set),
runs BACKUP DATABASE, finds the archive, unzips it and opens it, so it
runs on the native wheel too. Not run here: no tests could be run on the
authoring host.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
26.11.1 wheels write float and double arrays in the fixed-width form
(binary types 36 and 37, arcadedb.serializer.fixedWidthFloatArrays, on by
default). Read from upstream: the setting's default and text at 26.11.1,
ArcadeData/arcadedb#12234 (26.10.x and 26.9.1 open such a database without an
error, read the arrays as null, and the next UPDATE drops them) and #12239
(fd18fce4, main only: the dictionary is labelled format version 2 while the
setting is on, at the first read-write open, and builds from 26.8.1 to 26.11.x
refuse it; setting it to false before that open keeps a rollback possible).

The page has no upgrade or downgrade section, so a new one goes on the
installation page, with the safe rule and the system property route that the
durability page already documents. No static release-notes file exists: the
release notes are built from pull request titles (scripts/release_notes.py).
Not run: the Antora build (the Docs workflow does it).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@tae898 tae898 added documentation Improvements or additions to documentation native The arcadedb package (native library build) labels Nov 20, 2026
@tae898 tae898 self-assigned this Nov 20, 2026
@tae898
tae898 merged commit 0c3c7ec into main Nov 20, 2026
45 checks passed
@tae898
tae898 deleted the fix/native-backup-metadata-and-float-array-note branch November 20, 2026 09:52
@github-actions github-actions Bot added this to the 26.12.1 milestone Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation native The arcadedb package (native library build)

Projects

None yet

1 participant