fix(ui): show new run tabs immediately#164
Merged
Merged
Conversation
Owner
|
Thank you as always for the contribution! Nice design: keeping _onSessionCreated as the single idempotent upsert so POST-first and SSE-first orderings converge, plus the immediate tab render, is exactly the right shape, and the run() in-flight lock closes the double-click dupe. Verified locally: all 13 run-mode tests pass, typecheck/lint/frontend-syntax/public-assets/format all green, and I confirmed GET /api/sessions/:id goes through the preSerialization envelope so the fetch fallback parses correctly. One small note for a future pass: the welcome-screen buttons call runClaude()/runOpenCode()/runGemini() directly and so bypass the new lock; pre-existing behavior, not a blocker. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
session:createdSSE timingValidation
npm test -- test/run-mode-ui.test.ts(13 passed)npm run typechecknpm run lintnpm run check:frontend-syntaxnpm run check:public-assetsnpm run format:checknpm run buildPOST /api/sessionsrequest