drm/apple: iomfb: fix framebuffer retirement on DCP 14.7 - #583
Open
a-ramses wants to merge 1 commit into
Open
Conversation
DCP 14.7 expects the 0x234-byte A407 extension before the pointer-null flags. Linux placed the extension after the flags, so surface clear requests were not applied and stale framebuffer references could not be retired. Move the extension to the firmware layout and enable the existing framebuffer release paths for this ABI. Signed-off-by: a-ramses <abdicheramzi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix framebuffer retirement with DCP firmware ABI 14.7 by:
swapped_out_fbsretirement logic for ABI 14.7.Linux placed the null flags before the extension, so DCP did not process surface-clear requests. The workaround disabled framebuffer release for ABI 14.7.
Testing
Tested on T6030/M3 Pro: