fix(skills): keep a line break that is inside a quoted CSV cell

[L4XB]

All three spreadsheet scripts read a delimited file the same way:

rows = list(csv.reader(text.splitlines(), delimiter=delimiter))

csv.reader accepts any iterable of strings and does join a quoted cell that spans several of them — but splitlines() has already removed the break, so what the reader joins is "line one" + "line two" with nothing in between.

On a two-row file whose second column holds a note that spans lines:

ID,Note
1,"line one
line two"
2,plain

script	before	after
inspect_workbook.py	['1', 'line oneline two']	['1', 'line one\n line two']
csv_to_xlsx.py → B2	'line oneline two'	'line one\nline two'
validate_workbook.py	reads the same glued value	unchanged output, correct value

Measured on master (e0aa8d3) by running the three scripts over that file.

A cell that spans lines is ordinary in an exported sheet — a postal address, a product description, a comment column — and csv_to_xlsx.py writes the damage into the .xlsx it produces, so the loss outlives the tool call. Nothing reports it: the row count and the column count stay correct, because the reader did put the two halves in one field. Only the words are wrong.

Modifications / 改动点

io.StringIO(text, newline="") replaces text.splitlines() in inspect_workbook.py, validate_workbook.py and csv_to_xlsx.py. That is the form the csv documentation asks for, and it keeps the break inside the field. import io is added to each script; nothing else changes, and a file without a multi-line cell parses byte-identically.

• This is NOT a breaking change. / 这不是一个破坏性变更。

三个表格脚本都用 csv.reader(text.splitlines(), ...) 读取分隔文件。splitlines() 已经把换行删掉了，所以跨行的带引号单元格被拼接时，两边的词会粘在一起："line one\nline two" 变成 line oneline two，并且 csv_to_xlsx.py 会把这个错误写进生成的 .xlsx。改为 io.StringIO(text, newline="")，即 csv 文档推荐的写法。

Screenshots or Test Results / 运行截图或测试结果

test_spreadsheet_skill_keeps_a_line_break_inside_a_quoted_cell added to tests/test_builtin_office_skills.py. It runs inspect_workbook.py and csv_to_xlsx.py over the file above and asserts the sample and cell B2.

Against the unfixed scripts (git stash on the scripts/ directory only):

FAILED tests/test_builtin_office_skills.py::test_spreadsheet_skill_keeps_a_line_break_inside_a_quoted_cell
  At index 1 diff: ['1', 'line oneline two'] != ['1', 'line one\nline two']
1 failed, 4 deselected

With the fix:

$ python -m pytest tests/test_builtin_office_skills.py -q
5 passed

$ python -m pytest tests/ -q
2 failed, 3328 passed, 4 skipped

Both remaining failures are tests/test_fastapi_v1_dashboard.py::test_config_update_revokes_only_affected_shell_sessions; they fail the same way on a clean origin/master checkout and are unrelated to this change.

ruff check and ruff format --check are clean on all four files.

---

Checklist / 检查清单

• 😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
  / 如果 PR 中有新加入的功能，已经通过 Issue / 邮件等方式和作者讨论过。 (Bug fix, no new feature.)

• 👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
  / 我的更改经过了良好的测试，并已在上方提供了“验证步骤”和“运行截图”。

• 📚 I checked the affected WebUI instructions and screenshots in docs/zh and docs/en against the changed navigation, page structure, and labels, and updated them in this PR (or explained why no documentation update is needed).
  / 我已对照变化后的 WebUI 入口、页面结构和术语，核对并在本 PR 中更新 docs/zh 和 docs/en 的相关操作说明与截图（或说明无需更新文档的原因）。 (No WebUI entry point, page or label changes: this is inside three skill scripts.)

• 🤓 I have ensured that no new dependencies are introduced.
  / 我确保没有引入新依赖库。 (io is stdlib.)

• 😮 My changes do not introduce malicious code.
  / 我的更改没有引入恶意代码。

Summary by Sourcery

Preserve embedded line breaks when parsing delimited spreadsheet files.

Bug Fixes:

• Preserve line breaks in quoted multi-line CSV cells across spreadsheet inspection, conversion, and validation scripts, preventing cell contents from being concatenated incorrectly.

Tests:

• Add coverage verifying that multi-line quoted CSV values remain intact during inspection and XLSX conversion.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Needs a human reviewer. If the CSV parsing change is wrong, conversion could write incorrect cell values into generated XLSX files, and inspection or validation could report misleading results. Reverting stops future bad outputs, while existing files can be regenerated from the original CSV source.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook