test: re-enable authwit tests stale-skipped on additionalScopes - #18
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
alejoamiras
force-pushed
the
stack/reenable-tests
branch
from
August 12, 2026 12:49
0f00b97 to
6d9fdca
Compare
This comment has been minimized.
This comment has been minimized.
Seven tests were skipped with 'requires additionalScopes (not yet available)' — but the API has been available for some time and is already used successfully elsewhere in the same files. Re-enable all of them, passing additionalScopes on every third-party submission so the submitter's PXE can access the owner's notes: - token: private transfer with authwitness (carl submits for alice) - nft: both private-to-public authorization tests (bob submits for alice) - vault: all four private-flow suites; both call helpers and the six direct third-party sends now scope the note owner (the sender's own scope is included by default) Verified against a local network: token 1/1, nft 9/9, vault authwits 7/7. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
IlyasRidhuan
force-pushed
the
stack/reenable-tests
branch
from
August 12, 2026 16:40
6d9fdca to
1e9ceca
Compare
IlyasRidhuan
approved these changes
Aug 12, 2026
Benchmark Comparison
Contract: escrow
Contract: logic
Contract: multitoken
Contract: nft
Contract: token
Contract: vault
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Re-enables all seven integration tests skipped with "requires
additionalScopes(not yet available)" — a stale claim: the API exists and was already used successfully elsewhere in the same files.private transfer with authwitness(carl submits alice's transfer)Private assets, Public shares,Public assets, Private shares,Private assets, Private shares,Exact methods, Mixed Assets, Private shares)The fix on each third-party submission is
additionalScopes: [owner], so the submitter's PXE can access the owner's notes (balances/NFT note + account-contract signing key). In vault.test.ts this is wired into both call helpers plus the six directsend({ from: carl })calls. The sender's own scope is included by default — verified empirically (the pre-fix failure listed exactly[sender, zero]as allowed scopes).Validation
Against a local aztec network (v5.1.0): token 1/1 · nft 9/9 (whole file) · vault "Successful interactions with authwits." 7/7, including all four re-enabled suites.
Codex adversarial review: approved, no findings — no assertions weakened, no isolation/ordering risk, scope coverage complete.
🤖 Generated with Claude Code