test: fix wallet-internals fee call, paginate events, tighten asserts - #20
Merged
Merged
Conversation
- WalletWithInternals.completeFeeOptions declared the pre-5.1.0 3-arg signature; the real BaseWallet method takes a single options bag, so the caller-side AztecAddress destructured to all-undefined and only worked because the defaults happened to fit. Fix the signature, factor the three duplicated commitment helpers into one proveExtractAndSendCommitment, and guard the nested-result shape. - Rewrite the 'replace with simulate() + send()' TODOs: that migration is unsound (the commitment derives from randomness drawn fresh per execution) and no public API exposes private return values at 5.1.0. - Follow getPublicEvents nextCursor in the three event helpers instead of silently truncating at one page. - nft access-control test: match the auth failure message instead of accepting any error. - Fix the vault deploy NOTE (salt is settable via DeployOptions since v5.1.0; the actual blocker is the high-level path hardcoding a zero deployer) and bump the escrow TXE-oracle citation to v5.1.0. Validated: token 5/5, nft 9/9, multitoken 13/13 against a local network. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
IlyasRidhuan
force-pushed
the
stack/test-layer-fixes
branch
from
August 12, 2026 16:40
0b4abd1 to
30bd788
Compare
IlyasRidhuan
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Test-layer fixes from the modernization audit (all TS + comments, no contract changes):
completeFeeOptionslatent bug: ourWalletWithInternalstyped the pre-5.1.0 three-positional-arg signature; the realBaseWalletmethod takes a single options bag, so the passedAztecAddressdestructured to all-undefinedand only worked because the defaults happened to fit a fee-less call. Fixed, and the three duplicated commitment helpers are factored into oneproveExtractAndSendCommitmentwith a shape guard on the nested execution results.initialize_transfer_commitmentdraws fresh randomness per execution, so a simulated commitment never matches the sent tx. No public API exposes private return values at 5.1.0; the comment now says so.getPublicEventsreturns one page per call; the three event helpers now follownextCursorinstead of silently truncating.DeployOptions::with_saltsince v5.1.0 — the actual blocker is the high-level deploy path hardcoding a zero deployer); escrow TXE-oracle citation bumped to v5.1.0 (values re-verified unchanged).Validation
token 5/5 · nft 9/9 · multitoken 13/13 against a local network; prettier clean.
🤖 Generated with Claude Code