Skip to content

Pin the AMQP test broker hash to protect against changes - #7270

Open
LarryOsterman wants to merge 5 commits into
mainfrom
larryo/pin_amqp_test_version
Open

Pin the AMQP test broker hash to protect against changes#7270
LarryOsterman wants to merge 5 commits into
mainfrom
larryo/pin_amqp_test_version

Conversation

@LarryOsterman

Copy link
Copy Markdown
Member

Pull Request Checklist

Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:

See the detailed list in the contributing guide.

  • C++ Guidelines
  • Doxygen docs
  • Unit tests
  • No unwanted commits/changes
  • Descriptive title/description
    • PR is single purpose
    • Related issue listed
  • Comments in source
  • No typos
  • Update changelog
  • Not work-in-progress
  • External references or docs updated
  • Self review of PR done
  • Any breaking changes?

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 2 pipeline(s).
8 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@LarryOsterman
LarryOsterman force-pushed the larryo/pin_amqp_test_version branch from 0e094de to f173325 Compare August 3, 2026 18:12
@LarryOsterman
LarryOsterman marked this pull request as ready for review August 3, 2026 20:19
Copilot AI review requested due to automatic review settings August 3, 2026 20:19
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 2 pipeline(s).
8 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the azure-core-amqp test infrastructure to reduce sensitivity to external AMQP broker/environment changes by adjusting native-broker unit tests and the PowerShell test-broker setup script.

Changes:

  • Switched native-broker unit test setup failures from GTEST_FATAL_FAILURE_ to GTEST_SKIP_ when TEST_BROKER_ADDRESS is not present.
  • Updated Test-Setup.ps1 to re-clone the azure-amqp test broker repo and attempt to pin it to a specific commit hash.
  • Adjusted Test-Setup.ps1 broker build/run flow (including macOS early-exit behavior).

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
sdk/core/azure-core-amqp/test/ut/session_tests.cpp Skip native-broker tests when TEST_BROKER_ADDRESS is missing.
sdk/core/azure-core-amqp/test/ut/message_sender_receiver.cpp Skip native-broker tests when TEST_BROKER_ADDRESS is missing.
sdk/core/azure-core-amqp/test/ut/management_tests.cpp Skip native-broker tests when TEST_BROKER_ADDRESS is missing.
sdk/core/azure-core-amqp/test/ut/connection_tests.cpp Skip native-broker tests when TEST_BROKER_ADDRESS is missing.
sdk/core/azure-core-amqp/test/ut/claim_based_security_tests.cpp Skip native-broker tests when TEST_BROKER_ADDRESS is missing.
sdk/core/azure-core-amqp/Test-Setup.ps1 Reworked test-broker setup to (intended) pin a repo hash and change broker startup behavior.

Comment thread sdk/core/azure-core-amqp/Test-Setup.ps1
Comment thread sdk/core/azure-core-amqp/Test-Setup.ps1
Comment on lines +67 to +70
Set-Location -Path $WorkingDirectory/azure-amqp/bin/Debug/TestAmqpBroker/net10.0
$job = dotnet exec ./TestAmqpBroker.dll ${env:TEST_BROKER_ADDRESS} /headless &

$env:TEST_BROKER_JOBID = $Process.Id
$env:TEST_BROKER_JOBID = $job.Id
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants