Pin the AMQP test broker hash to protect against changes - #7270
Open
LarryOsterman wants to merge 5 commits into
Open
Pin the AMQP test broker hash to protect against changes#7270LarryOsterman wants to merge 5 commits into
LarryOsterman wants to merge 5 commits into
Conversation
|
Azure Pipelines: Successfully started running 2 pipeline(s). 8 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
LarryOsterman
force-pushed
the
larryo/pin_amqp_test_version
branch
from
August 3, 2026 18:12
0e094de to
f173325
Compare
LarryOsterman
marked this pull request as ready for review
August 3, 2026 20:19
LarryOsterman
requested review from
RickWinter,
antkmsft and
xirzec
as code owners
August 3, 2026 20:19
|
Azure Pipelines: Successfully started running 2 pipeline(s). 8 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the azure-core-amqp test infrastructure to reduce sensitivity to external AMQP broker/environment changes by adjusting native-broker unit tests and the PowerShell test-broker setup script.
Changes:
- Switched native-broker unit test setup failures from
GTEST_FATAL_FAILURE_toGTEST_SKIP_whenTEST_BROKER_ADDRESSis not present. - Updated
Test-Setup.ps1to re-clone theazure-amqptest broker repo and attempt to pin it to a specific commit hash. - Adjusted
Test-Setup.ps1broker build/run flow (including macOS early-exit behavior).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/core/azure-core-amqp/test/ut/session_tests.cpp | Skip native-broker tests when TEST_BROKER_ADDRESS is missing. |
| sdk/core/azure-core-amqp/test/ut/message_sender_receiver.cpp | Skip native-broker tests when TEST_BROKER_ADDRESS is missing. |
| sdk/core/azure-core-amqp/test/ut/management_tests.cpp | Skip native-broker tests when TEST_BROKER_ADDRESS is missing. |
| sdk/core/azure-core-amqp/test/ut/connection_tests.cpp | Skip native-broker tests when TEST_BROKER_ADDRESS is missing. |
| sdk/core/azure-core-amqp/test/ut/claim_based_security_tests.cpp | Skip native-broker tests when TEST_BROKER_ADDRESS is missing. |
| sdk/core/azure-core-amqp/Test-Setup.ps1 | Reworked test-broker setup to (intended) pin a repo hash and change broker startup behavior. |
Comment on lines
+67
to
+70
| Set-Location -Path $WorkingDirectory/azure-amqp/bin/Debug/TestAmqpBroker/net10.0 | ||
| $job = dotnet exec ./TestAmqpBroker.dll ${env:TEST_BROKER_ADDRESS} /headless & | ||
|
|
||
| $env:TEST_BROKER_JOBID = $Process.Id | ||
| $env:TEST_BROKER_JOBID = $job.Id |
xirzec
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.