Storage - STG105 NFS List V2 Files and Directories - #50036
Open
gunjansingh-msft wants to merge 1 commit into
Open
Storage - STG105 NFS List V2 Files and Directories#50036gunjansingh-msft wants to merge 1 commit into
gunjansingh-msft wants to merge 1 commit into
Conversation
gunjansingh-msft
requested review from
a team,
Alan Zimmer (alzimmermsft),
browndav-msft,
Isabelle (ibrandes),
Kyle Knapp (kyleknap) and
Sean McCullough (seanmcc-msft)
as code owners
August 5, 2026 14:17
|
Azure Pipelines: Successfully started running 1 pipeline(s). 35 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Restores the NFS List V2 Files and Directories feature (#49246), which was reverted from stg104 in #49770, rebased onto stg105base. Handwritten files match #49246 exactly. Generated code was produced by running autorest against the swagger link from Azure/azure-rest-api-specs#42720 already configured in the swagger README. The only handwritten deviations from #49246 are those forced by this base: - DirectoryListingDeserializationTests uses V2027_03_07; V2026_12_06 does not exist in ShareServiceVersion on stg105base. - Dropped the ArrayList import in the two ShareDirectory clients; it is unused here and fails checkstyle. - ModelHelper omits toShareFileRangeItems and its imports. That helper is STG103 paginated Get Range work, which is not on this base and is unrelated to this feature. Recordings are not included. assets.json stays at the stg105base tag until the feature is enabled in canary and the tests can be re-recorded.
gunjansingh-msft
force-pushed
the
stg105/nfsListV2
branch
from
August 5, 2026 15:18
f140d59 to
1ea8a45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for XNFS ListFilesV2 REST API enhancements to return extended metadata for NFS files directly from the list response.
This restores #49246, which was reverted from stg104 in #49770, now targeting stg105.
Swagger PR: Azure/azure-rest-api-specs#42720
Changes
ShareFileItem— newgetLinkCount(),getFileType(),getLinkText(),getDeviceMajor(),getDeviceMinor()ShareFileItemProperties— newgetOwner(),getGroup(),getFileMode()NfsFileType— newBLOCK_DEVICE,CHARACTER_DEVICE,SOCKET,FIFOShareListFilesAndDirectoriesOptions— newsetIncludePermissions,setIncludeLinkCount,setIncludeNfsAttributes,setIncludeAll.setIncludeAllsends the singleAllvalue to the service rather than expanding it, since not all values apply to both SMB and NFSFileTypeis always populated for files and directories on both SMB and NFS, based on the XML element type returned by the serviceImpact
Testing
ShareFileTraits.Allon SMB are included but not yet recorded.assets.jsonstays at the stg105base tag until the feature is enabled in canary, so playback for these two tests will fail until they are re-recorded againstseancettcanaryfilesprem