Sync eng/common directory with azure-sdk-tools for PR 16662 - #50043
Merged
Chidozie Ononiwu (chidozieononiwu) merged 1 commit intoAug 6, 2026
Merged
Conversation
azure-sdk-automation
Bot
requested a review
from Chidozie Ononiwu (chidozieononiwu)
August 5, 2026 18:21
azure-sdk-automation
Bot
added
EngSys
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot could not run the full agentic suite for this review because it was automatically requested on a bot-authored pull request. Request a review from Copilot under Reviewers to retry with the full agentic suite. Improved support for bot-authored pull requests is coming soon.
Adds an option to force owner-suffixed GitHub token variable names even when only a single owner is requested, improving consistency for downstream consumers.
Changes:
- Add
AlwaysUseOwnerSuffixswitch tologin-to-github.ps1to optionally always export<Prefix>_<Owner>. - Expose
AlwaysUseOwnerSuffixas a boolean parameter in the Azure Pipelineslogin-to-github.ymlstep template and pass it through to the script.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| eng/common/scripts/login-to-github.ps1 | Adds a new switch and updates variable naming logic for exported token variables. |
| eng/common/pipelines/templates/steps/login-to-github.yml | Adds a template parameter and forwards it to the PowerShell script invocation. |
Comment on lines
22
to
+27
| Prefix for the exported variable name (default: GH_TOKEN). | ||
| With a single owner, exports as GH_TOKEN. With multiple owners, exports as GH_TOKEN_<Owner>. | ||
|
|
||
| .PARAMETER AlwaysUseOwnerSuffix | ||
| Export tokens as <VariableNamePrefix>_<Owner> even when only one owner is requested. | ||
|
|
|
Azure Pipelines: Successfully started running 1 pipeline(s). 34 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
azure-sdk-automation
Bot
force-pushed
the
sync-eng-common-expandEngCommonWorkflow-16662
branch
2 times, most recently
from
August 5, 2026 22:23
e0e2e27 to
691287f
Compare
azure-sdk-automation
Bot
force-pushed
the
sync-eng-common-expandEngCommonWorkflow-16662
branch
from
August 6, 2026 18:49
691287f to
3442d70
Compare
Chidozie Ononiwu (chidozieononiwu)
approved these changes
Aug 6, 2026
Chidozie Ononiwu (chidozieononiwu)
deleted the
sync-eng-common-expandEngCommonWorkflow-16662
branch
August 6, 2026 22:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#16662 See eng/common workflow