Skip to content

[AzureMonitorAutoConfigure] Align customer SDKStats with stable spec - #50056

Open
Jackson Weber (JacksonWeber) wants to merge 3 commits into
Azure:mainfrom
JacksonWeber:jacksonweber/customer-sdk-stats-spec
Open

[AzureMonitorAutoConfigure] Align customer SDKStats with stable spec#50056
Jackson Weber (JacksonWeber) wants to merge 3 commits into
Azure:mainfrom
JacksonWeber:jacksonweber/customer-sdk-stats-spec

Conversation

@JacksonWeber

Copy link
Copy Markdown
Member

Description

Aligns the existing customer-facing SDKStats implementation with the stable telemetry specification while preserving its current on-by-default rollout.

Changes

  • Read public SDKStats disable and export interval environment variables through their OpenTelemetry-normalized configuration property names.
  • Preserve the exact-case APPLICATIONINSIGHTS_SDKStats_DISABLED_ALL global kill switch.
  • Rename custom dimensions to the stable specification names:
    • telemetryType
    • telemetrySuccess
    • dropCode / dropReason
    • retryCode / retryReason
  • Report the actual Azure Monitor distro version instead of unknown in the version dimension.
  • Add payload-level, configuration precedence, and version-resolution tests.
  • Update README, changelog, and the SDKStats manual sample documentation.

Validation

  • Focused SDKStats tests pass.
  • Full module test suite passes: 361 tests, 0 failures, 0 errors.
  • Checkstyle and SpotBugs pass.
  • Live validation against a new Application Insights resource confirmed default-on Item_Success_Count records for REQUEST, DEPENDENCY, EXCEPTION, and CUSTOM_METRIC telemetry with stable dimensions and version 1.6.0-beta.1.

All SDK Contribution checklist

  • The pull request does not introduce breaking API changes.
  • CHANGELOG is updated.
  • I have read the contribution guidelines.
  • Tests cover the changes.

Align customer-facing SDKStats configuration and dimensions with the stable telemetry contract, keep the feature disabled by default, and report the actual distro version.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 8908d3b5-202b-4ce8-b5da-509cbc2a360c
Preserve the existing default-on rollout while retaining stable dimension names, normalized disable and interval configuration, and accurate distro version reporting.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 8908d3b5-202b-4ce8-b5da-509cbc2a360c
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
34 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
34 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Note

This error may be related to your runner configuration. You can now configure runners for Copilot code review separately from Copilot cloud agent by creating a copilot-code-review.yml file with your setup steps. Read the docs for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants