Repository navigation
Add configurable Blob endpoint for Data Lake clients - #50296
Arnab Nandy (arnabnandy7) wants to merge 2 commits into
Conversation
|
Thank you for your contribution Arnab Nandy (@arnabnandy7)! We will review the pull request and get back to you soon. |
|
Azure Pipelines: Successfully started running 1 pipeline(s). 34 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
Pull request overview
Adds a new builder option to the Data Lake SDK to allow configuring a separate Blob service endpoint (useful for proxy/custom-host setups where DFS and Blob are exposed via different hostnames), while keeping the existing “derive blob endpoint from dfs endpoint” behavior as the default.
Changes:
- Added
DataLakeServiceClientBuilder.blobEndpoint(String)to explicitly set the Blob service endpoint. - Added unit tests to validate explicit endpoint behavior and ordering for sync/async client creation.
- Updated README, samples, and CHANGELOG to document and demonstrate the new configuration.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| sdk/storage/azure-storage-file-datalake/src/main/java/com/azure/storage/file/datalake/DataLakeServiceClientBuilder.java | Introduces blobEndpoint(String) and preserves explicit blob endpoint across endpoint(String) calls. |
| sdk/storage/azure-storage-file-datalake/src/test/java/com/azure/storage/file/datalake/UrlTests.java | Adds sync/async tests validating explicit Blob endpoint configuration and ordering. |
| sdk/storage/azure-storage-file-datalake/src/samples/java/com/azure/storage/file/datalake/ReadmeSamples.java | Adds a README-aligned sample showing separate DFS/Blob proxy endpoints. |
| sdk/storage/azure-storage-file-datalake/README.md | Documents how to configure separate DFS and Blob endpoints with a snippet. |
| sdk/storage/azure-storage-file-datalake/CHANGELOG.md | Adds an unreleased feature note for the new builder API. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
503cbbb to
49e6518
Compare
49e6518 to
ef87562
Compare
Signed-off-by: Arnab Nandy <arnab_nandy7@yahoo.com>
ef87562 to
7b0608a
Compare
|
Hi Arnab Nandy (@arnabnandy7). Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
Description
Adds support for configuring the Blob service endpoint separately from the Data Lake service endpoint through
DataLakeServiceClientBuilder.blobEndpoint(String).Previously, the Blob endpoint was always derived from the configured Data Lake endpoint by converting the
.dfs.hostname segment to.blob.. This does not work when the two services are exposed through distinct custom or reverse-proxy hostnames.The existing endpoint derivation remains the default when
blobEndpoint(String)is not configured, preserving backward compatibility. The explicit Blob endpoint is also preserved regardless of whether it is configured before or afterendpoint(String).Fixes #49781
This change includes:
DataLakeServiceClientBuilder.blobEndpoint(String)API.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines