Repository navigation
[Storage] Queue SAS Timezone Tests - #50718
Draft
Isabelle (ibrandes) wants to merge 2 commits into
Draft
Isabelle (ibrandes) wants to merge 2 commits into
Isabelle (ibrandes) wants to merge 2 commits into
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). 34 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused offline tests correctly validate UTC normalization and deterministic signing without production changes.
0 open findings
What changed in this PR
Adds offline regression coverage for timezone-aware Queue SAS expiry handling.
Changes:
- Verifies non-UTC expiries are converted to UTC.
- Confirms equivalent instants produce identical SAS signatures.
| File | Description |
|---|---|
QueueSasTests.java |
Adds deterministic timezone and signature regression tests. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.