Test: replicate #60388 to validate scoped Verify Generated Code (do not merge)#60407
Open
m-nash wants to merge 1 commit into
Open
Test: replicate #60388 to validate scoped Verify Generated Code (do not merge)#60407m-nash wants to merge 1 commit into
m-nash wants to merge 1 commit into
Conversation
…erify Generated Code Replicates the exact file changes from #60388 (peel 25 packages off the NoWarn skip list) so the analyze 'Verify Generated Code' wall-clock can be compared against the project-scoped regeneration in feature/scope-verify-generated-to-projects. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
m-nash
requested review from
a team,
ArcturusZhang,
ArthurMa1978,
JialinXin,
Kishp01,
KrzysztofCwalina,
andykao1213,
asaflevi-ms,
benbp,
danieljurek,
dubiety,
jsquire,
koen-mertens,
quentinRobinson,
rajeshka,
shankarsama,
tomsft and
vicancy
as code owners
github-actions
Bot
added
Cognitive - Health Insights
Cognitive - Text Analytics
Event Grid
Extensions
Contributor
There was a problem hiding this comment.
Pull request overview
Test-only PR that mirrors #60388’s “dead NoWarn sweep” changes to validate that Verify Generated Code regeneration is scoped to changed projects (instead of whole service directories) on feature/scope-verify-generated-to-projects.
Changes:
- Removes now-unneeded per-project
<NoWarn>suppressions from a set of SDK projects (primarilyAzure.Provisioning.*plus a few others). - Removes the corresponding project entries from
eng/NoWarnSkipValidation.txtso NoWarn validation no longer short-circuits for those projects.
Reviewed changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/websites/Azure.Provisioning.AppService/src/Azure.Provisioning.AppService.csproj | Removes redundant CS1591 <NoWarn> entry. |
| sdk/webpubsub/Microsoft.Azure.Functions.Worker.Extensions.WebPubSub/src/Microsoft.Azure.Functions.Worker.Extensions.WebPubSub.csproj | Removes redundant analyzer suppression (CA2227) from project. |
| sdk/webpubsub/Azure.Messaging.WebPubSub/src/Azure.Messaging.WebPubSub.csproj | Removes redundant <NoWarn> entry. |
| sdk/webpubsub/Azure.Messaging.WebPubSub.Client/src/Azure.Messaging.WebPubSub.Client.csproj | Removes redundant <NoWarn> entry. |
| sdk/textanalytics/Azure.AI.TextAnalytics.Legacy.Shared/src/Azure.AI.TextAnalytics.Legacy.csproj | Removes now-stale “global warning suppressions” property group. |
| sdk/servicenetworking/Azure.Provisioning.ServiceNetworking/src/Azure.Provisioning.ServiceNetworking.csproj | Removes redundant CS1591 <NoWarn> entry. |
| sdk/securitycenter/Azure.Provisioning.SecurityCenter/src/Azure.Provisioning.SecurityCenter.csproj | Removes redundant <NoWarn> entry (including CS1591 and AZPROVISION001). |
| sdk/resourcegraph/Azure.Provisioning.ResourceGraph/src/Azure.Provisioning.ResourceGraph.csproj | Removes redundant CS1591 <NoWarn> entry. |
| sdk/mysql/Azure.Provisioning.MySql/src/Azure.Provisioning.MySql.csproj | Removes redundant CS1591 <NoWarn> entry. |
| sdk/monitor/Azure.Provisioning.Monitor/src/Azure.Provisioning.Monitor.csproj | Removes redundant CS1591 <NoWarn> entry. |
| sdk/maps/Azure.Maps.Common/src/Azure.Maps.Common.csproj | Removes redundant analyzer suppression (AZC0012) from project. |
| sdk/logic/Azure.Provisioning.Logic/src/Azure.Provisioning.Logic.csproj | Removes redundant CS1591 <NoWarn> entry. |
| sdk/keyvault/Azure.Provisioning.KeyVault/src/Azure.Provisioning.KeyVault.csproj | Removes redundant CS1591 <NoWarn> entry. |
| sdk/healthinsights/Azure.Health.Insights.ClinicalMatching/src/Azure.Health.Insights.ClinicalMatching.csproj | Removes redundant <NoWarn> entry (CS1591;AZC0012). |
| sdk/healthinsights/Azure.Health.Insights.CancerProfiling/src/Azure.Health.Insights.CancerProfiling.csproj | Removes redundant <NoWarn> entry (CS1591;AZC0012). |
| sdk/extensions/Microsoft.Azure.WebJobs.Extensions.Clients/src/Microsoft.Azure.WebJobs.Extensions.Clients.csproj | Removes redundant analyzer suppression (CA1812) from project. |
| sdk/eventgrid/Azure.Messaging.EventGrid.Namespaces/src/Azure.Messaging.EventGrid.Namespaces.csproj | Removes redundant <NoWarn> entry (CS1574). |
| sdk/datafactory/Azure.Provisioning.DataFactory/src/Azure.Provisioning.DataFactory.csproj | Removes redundant CS1591 <NoWarn> entry. |
| sdk/cosmosdb/Azure.Provisioning.CosmosDB/src/Azure.Provisioning.CosmosDB.csproj | Removes redundant CS1591 <NoWarn> entry. |
| sdk/containerinstance/Azure.Provisioning.ContainerInstance/src/Azure.Provisioning.ContainerInstance.csproj | Removes redundant CS1591 <NoWarn> entry. |
| sdk/compute/Azure.Provisioning.Compute/src/Azure.Provisioning.Compute.csproj | Removes redundant CS1591 <NoWarn> entry. |
| sdk/cognitiveservices/Azure.Provisioning.CognitiveServices/src/Azure.Provisioning.CognitiveServices.csproj | Removes redundant CS1591 <NoWarn> entry. |
| sdk/cdn/Azure.Provisioning.Cdn/src/Azure.Provisioning.Cdn.csproj | Removes redundant CS1591 <NoWarn> entry. |
| sdk/batch/Azure.Provisioning.Batch/src/Azure.Provisioning.Batch.csproj | Removes redundant CS1591 <NoWarn> entry. |
| sdk/apimanagement/Azure.Provisioning.ApiManagement/src/Azure.Provisioning.ApiManagement.csproj | Removes redundant CS1591 <NoWarn> entry. |
| eng/NoWarnSkipValidation.txt | Removes the corresponding projects from the NoWarn validation skip list. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Test PR — do not merge. This replicates the exact file changes from #60388 (peel 25 packages off the NoWarn skip list, 26 files / 76 deletions) and targets
feature/scope-verify-generated-to-projectsso the analyzeVerify Generated Codewall-clock runs with the project-scoped regeneration from that branch.What we are validating
On #60388, the analyze batch (~177k weighted LOC) ran ~52 min, dominated by
Verify Generated Coderegenerating co-located management-plane packages that the PR never touched (e.g.Azure.ResourceManager.DataFactory~14.5 min,Azure.ResourceManager.ApiManagement~5 min,Azure.ResourceManager.SecurityCenter~3.3 min) because regeneration was scoped per service directory.With the feature branch's change, regeneration is scoped to the changed projects (the
Azure.Provisioning.*packages), so those mgmt regenerations should no longer run. We expect the analyze batches here to finish dramatically faster than #60388.How to read the result
Compare the
Build Analyze PRBatch_*job durations on this PR against #60388's ~52 min. Success = the analyze batches drop to a few minutes and theVerify Generated Codestep no longer regenerates co-locatedAzure.ResourceManager.*packages.