Skip to content

Sync eng/common directory with azure-sdk-tools for PR 17441 - #49873

Open
azure-sdk-automation[bot] wants to merge 3 commits into
mainfrom
sync-eng-common-feat/specs-skill-eval-dashboard-17441
Open

azure-sdk-automation[bot] wants to merge 3 commits into
mainfrom
sync-eng-common-feat/specs-skill-eval-dashboard-17441

Conversation

@azure-sdk-automation

Copy link
Copy Markdown
Contributor

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#17441 See eng/common workflow

@azure-sdk-automation
azure-sdk-automation Bot requested review from Helen Gao (helen229) and a balanced review from Copilot November 6, 2026 19:57
@azure-sdk-automation azure-sdk-automation Bot added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Nov 6, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
9 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Expanding credential-bearing publishing and pipeline-wide storage egress to eligible Azure repositories requires security review of service-connection authorization, branch protections, and RBAC that cannot be verified from this snapshot.

No open issues 🎉

What changed in this PR

Syncs shared evaluation publishing infrastructure from azure-sdk-tools PR #17441, allowing opted-in Azure-owned repositories to publish results without a per-repository allowlist.

Changes:

  • Broadens publishing and storage-egress gates while retaining private -pr repository exclusions and trusted-run checks.
  • Adds tests for repository eligibility, pipeline identity, and completed evaluations with failing grades.
  • Documents repository opt-in, service-connection authorization, and storage requirements.
File Description
eng/​common/​scripts/​eval/​README.md Documents expanded eligibility and pipeline-owner setup requirements.
eng/​common/​scripts/​eval/​publisher/​test/​publisher.test.ts Tests expanded trust gates and preservation of bundle identity and failing results.
eng/​common/​scripts/​eval/​publisher/​CHANGELOG.md Records expanded shared-publisher support.
eng/​common/​pipelines/​templates/​steps/​eval-publish-results.yml Updates compile-time and runtime publishing eligibility.
eng/​common/​pipelines/​templates/​stages/​archetype-eval.yml Applies the expanded eligibility policy to storage egress.

Review effort: Balanced

@helen229 Helen Gao (helen229) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve the eng/common sync from Azure/azure-sdk-tools#17441 at source f4ce21a52e4c2cba019791ac8e3443dc2b2006e6. All five synced files match that source revision. The change retains repository-local opt-in, internal-project/main-branch trust checks, owner authorization and complete-summary requirements; no release approval is granted by this review.

@helen229
Helen Gao (helen229) enabled auto-merge (squash) November 6, 2026 20:10

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants