Upgrade SQL version for Pipelines#3697
Open
RubenCerna2079 wants to merge 5 commits into
Open
Conversation
RubenCerna2079
requested review from
Alekhya-Polavarapu,
Aniruddh25,
JerryNixon,
aaronburtle,
anushakolan,
rusamant,
sourabh1007,
souvikghosh04,
stuartpa and
vadeveka
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the SQL Server versions used by CI pipelines and test schema initialization so that MsSql/DwSql integration tests can run against SQL Server 2025 features (notably the vector data type), addressing issue #3696.
Changes:
- Added a
vector_type_table(including a max-dimensionvector(1998)case) to the MsSql test schema so schema initialization fails on older SQL versions. - Updated pipeline LocalDB installer URL and version code to SQL 2025 equivalents.
- Updated the Linux SQL Server container image tag used in pipeline setup to SQL Server 2025.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Service.Tests/DatabaseSchema-MsSql.sql | Adds a new vector_type_table and seed data to require SQL Server 2025 vector support during schema init. |
| src/Service.Tests/dab-config.MsSql.json | Minor formatting/EOF change only (no functional config updates). |
| scripts/start-mssql-server.bash | Updates the SQL Server Linux container image tag to 2025. |
| .pipelines/mssql-pipelines.yml | Updates LocalDB installer URL and SQL version code for MsSql pipeline jobs. |
| .pipelines/dwsql-pipelines.yml | Updates LocalDB installer URL and SQL version code for DwSql pipeline jobs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
What is this change?
Changed the
SqlLocalDB.msito use the new SQL 2025 version, and updated all the places where we set the SQL version to use SQL 2025.How was this tested?
Added a table with a vector data type. If the SQL version is anything less than 2025, the pipeline would fail.
Sample Request(s)
N/A