Add test coverage for past expires_on in Managed Identity#940
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a regression test to ensure Managed Identity token acquisition correctly handles an MI endpoint response containing a past expires_on timestamp, preventing an accidentally long-lived token lifetime and ensuring a subsequent request re-hits the MI endpoint rather than returning a stale cached token.
Changes:
- Add a new App Service MI test covering past
expires_onhandling. - Assert
expires_inderived fromexpires_onis non-positive for past timestamps. - Assert a second acquisition re-calls the MI endpoint (no cache hit for an already-expired token).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Follow-up to review feedback: the second comment overstated that the token is not cached; the test proves it is not served (endpoint is re-hit), not that no entry is written. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Avery-Dunn
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a regression test in
tests/test_mi.pyfor a previously-uncovered Managed Identity edge case: when the MI endpoint returns a pastexpires_ontimestamp.Existing MI tests only use current/future
expires_onvalues. This test verifies that a past timestamp is treated as already-expired:expires_inderived from a pastexpires_onis non-positive (not an inflated lifetime).acquire_token_for_clientre-hits the endpoint, so the stale token is not served from cache.