Skip to content

fix: Replace iconv hard dependency with polyfill - #245

Open
danog wants to merge 1 commit into
Bacon:mainfrom
danog:main
Open

danog wants to merge 1 commit into
Bacon:mainfrom
danog:main

Conversation

@danog

@danog danog commented Sep 16, 2026

Copy link
Copy Markdown

Technically this could be done by users, but some may not know about the existence of the polyfill, this PR always requires it to avoid this pitfall.

@codecov

codecov Bot commented Sep 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.72%. Comparing base (c0c9671) to head (7b14215).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #245   +/-   ##
=========================================
  Coverage     71.72%   71.72%           
  Complexity      999      999           
=========================================
  Files            49       49           
  Lines          3158     3158           
=========================================
  Hits           2265     2265           
  Misses          893      893           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@danog danog changed the title Replace iconv hard dependency with polyfill fix: Replace iconv hard dependency with polyfill Sep 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant