[CI dry-run] Extend lint_source.py: stop/error stop, integer(wp), signed d-literals (#1485) - #2
Open
BakaOverflow wants to merge 28 commits into
Open
[CI dry-run] Extend lint_source.py: stop/error stop, integer(wp), signed d-literals (#1485)#2BakaOverflow wants to merge 28 commits into
BakaOverflow wants to merge 28 commits into
Conversation
BakaOverflow
force-pushed
the
fix-issue-1485
branch
from
August 12, 2026 02:21
ccd7039 to
62a16ff
Compare
The post-build smoke test launched the syscheck binary directly. Since the August 11-13 PACE maintenance, which upgraded Phoenix to Slurm 26.05.2 with PMIx 4.2.6, an OpenMPI 4.1.5 binary started bare inside an allocation reads the PMIx environment as an srun launch and aborts in MPI_Init: OPAL ERROR: Unreachable in file ext3x_client.c at line 112 The application appears to have been direct launched using "srun", but OMPI was not built with SLURM's PMI support and therefore cannot execute. Every Phoenix job then failed validation twice and exited 1 before the test step ran, blocking all pull requests. mpirun is unaffected, and it is how MFC launches every other binary, so the smoke test now goes through it. The guard still catches what it was added for: a binary compiled for the wrong microarchitecture still dies on SIGILL and mpirun propagates the failure. Output is no longer sent to /dev/null, so the next failure is readable in the CI log instead of appearing as a bare "Post-build validation failed".
Co-authored-by: Spencer Bryngelson <sbryngelson@gmail.com>
Co-authored-by: Daniel Vickers <danieljvickers@login10.frontier.olcf.ornl.gov> Co-authored-by: Daniel Vickers <danieljvickers@login07.frontier.olcf.ornl.gov> Co-authored-by: Daniel Vickers <vickers9@tuolumne1001.llnl.gov> Co-authored-by: Spencer Bryngelson <sbryngelson@gmail.com>
Co-authored-by: Spencer Bryngelson <sbryngelson@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI dry-run before submitting to MFlowCode. Branch rebased on current master. Adds three lint_source.py checks (stop/error stop -> s_mpi_abort, integer(wp), signed/multi-digit d-exponent literals) + 6 unit tests, fixes the 5 existing violations, and relocates the nb guard into s_check_inputs_common. Verifying the full build/test matrix and the lint/spell gates pass. Not intended to merge into the fork.