Repository navigation
Issue certificates in the image and correct silent mail failures - #19
Merged
Merged
Conversation
Operators should get STARTTLS from the published image alone, and a failed certificate, a redirect, or a DNS error should not be reported as a successful delivery. Co-authored-by: Cursor <cursoragent@cursor.com>
golangci-lint v2.15 rejects Listener.Policy, and the organizational-domain helper was unused after alignment moved to the public suffix list. Co-authored-by: Cursor <cursoragent@cursor.com>
Go 1.26.3 and golang.org/x/net v0.54.0 are in the vulnerable range for GO-2026-6809 and GO-2026-6617. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The published image should obtain a certificate and start mail without a wrapper script, and a failure along the way should stay a failure instead of being reported as success.
devnull@localhostwhen no account email is provided. Issuance is skipped or allowed to fail without stopping SMTP. Empty or unreadable certificate files are not passed to the process. The Cloudflare token is removed from the environment before SMTP starts, and the process drops to the unprivileged user after writing/cert.SIGTERMis handled beforeServeblocks, a failed bind closes both listeners, and direct clients no longer wait out the PROXY header timeout for the 220 banner. A secondMAIL FROMclears recipients from the aborted transaction. The recipient cap stays on the session, because go-smtp's own counter is not cleared whenMAILrestarts a transaction.MESSAGE_PROCESSING_TIMEOUTbounds SPF, DKIM, and DMARC.pct=0is included in the DMARC JSON. Webhook metrics label the status with the numeric code.Test plan
go test -count=1 ./...CF_TokenandCF_Zone_IDunset and confirm SMTP starts without STARTTLS/certand confirm the process stays up without STARTTLSSIGTERMto a running server and confirm it exits after the shutdown logMade with Cursor