Repository navigation
Let Windows CI accept its signal and bind errors - #21
Merged
Merged
Conversation
Windows cannot deliver SIGINT or SIGTERM to a child, and a taken port is reported as a socket already in use rather than the Unix wording. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Main failed after the slim-runner merge because the push matrix runs Windows, and the pull request checks do not. Two tests assume Unix behavior.
TestApp_Run_WithSignalHandlingandTestApp_Run_GoRoutinesCoveragesendSIGTERMandSIGINTto a child process. Windows returnssignal: not supported. Those tests skip on Windows. The shutdown path is still covered on Linux and macOS.TestSMTPServer_Start_PlainBindFailureReturnsexpectedaddress already in use. Windows reportsOnly one usage of each socket address. The test now accepts both, and still checks that the TLS port is released.Test plan
go test ./internal/app -run 'TestApp_Run_WithSignalHandling|TestApp_Run_GoRoutinesCoverage'go test ./internal/smtp -run TestSMTPServer_Start_PlainBindFailureReturnsMade with Cursor