Repository navigation
chore: architecture review fixes (locked sync, warnings as errors, pre-commit in CI) - #57
Merged
Merged
Conversation
Re-lock uv.lock, which had drifted from pyproject.toml: requires-python changed in #56 and ruff>=0.17.0 was required while the lock pinned 0.16.10. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Drop '-p no:warnings', which silenced the warnings plugin entirely, and set filterwarnings = ["error"] so deprecations surface as test failures. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- pre-commit-hooks v5.0.0 -> v6.0.0, ruff-pre-commit v0.16.6 -> v0.17.1 (matches ruff in uv.lock) - Rename legacy 'ruff' hook id to 'ruff-check' - Keep Markdown hard line breaks in trailing-whitespace - New pre-commit CI job so gitleaks runs on every push Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Notable: filelock 3.32.5 -> 4.2.0 (major, transitive via virtualenv), pre-commit 4.6.2 -> 4.7.0, pluggy 1.6.0 -> 1.7.0, coverage 7.16.0 -> 7.16.2, platformdirs 4.11.7 -> 4.13.3, plus 13 patch/minor bumps. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to an architecture review of the tooling and CI setup.
Changes
uv sync --locked: CI now fails ifuv.lockdoesn't matchpyproject.toml. The lock onmainwas already out of date:requires-pythonchanged in ci: drop Python 3.10 (EOL), add Python 3.15 #56, and the lock had ruff 0.16.10 whileruff>=0.17.0is required. Re-locked in the same commit.-p no:warnings, which turned off the warnings plugin, and addedfilterwarnings = ["error"]. Deprecations now fail tests, which matters now that 3.15 is in the matrix.pre-commit-hooksv5.0.0 → v6.0.0 andruff-pre-commitv0.16.6 → v0.17.1 (matches the lock). Renamed the oldruffhook id toruff-check. Markdown hard line breaks are kept. Newpre-commitCI job, so gitleaks runs on every push.Verification
Locally:
uv lock --check,make test mypy lint format-checkandmake pre-commitall pass.🤖 Generated with Claude Code