Skip to content

Lucarelli visualization - #286

Merged
plakrisenko merged 8 commits into
masterfrom
lucarelli_visualization_spec
Nov 13, 2025
Merged

Lucarelli visualization#286
plakrisenko merged 8 commits into
masterfrom
lucarelli_visualization_spec

Conversation

@plakrisenko

@plakrisenko plakrisenko commented Oct 31, 2025

Copy link
Copy Markdown
Collaborator

I am not sure that I correctly identified data from the figures in the original publication.
So the notes in the measurements table and the visualization table (the rightmost column) are just my guesses.

@plakrisenko
plakrisenko requested a review from stephanmg October 31, 2025 15:44
@stephanmg

Copy link
Copy Markdown
Collaborator

Can I somewhere preview the visualization? Could you add please an image?

@plakrisenko

Copy link
Copy Markdown
Collaborator Author

Fig.1 , A
plot37

Is there supposed to be an offset?
image

@stephanmg

Copy link
Copy Markdown
Collaborator

Axis label is nan - that should be corrected.

@plakrisenko

Copy link
Copy Markdown
Collaborator Author

Fig.1, B
plot39

vs
image

@plakrisenko

Copy link
Copy Markdown
Collaborator Author

I am to sure what this figure is:
plot41

Could be Fig. 3, A, the first blue bar:
image

However, I don't see the rest in the measurements table.

@stephanmg

Copy link
Copy Markdown
Collaborator

Unclear for me as well, first figure is okay.

@plakrisenko

plakrisenko commented Nov 1, 2025

Copy link
Copy Markdown
Collaborator Author

Fig. 2, D, right column. These seem to match the publication
plot1

plot2 plot3 plot4

@plakrisenko

Copy link
Copy Markdown
Collaborator Author

Figure 1
figure1

Figure 2
figure2

Figure 3, 1-4 (different initial conditions)
figure3F_1

figure3F_2 figure3F_3 figure3F_4

@plakrisenko
plakrisenko marked this pull request as ready for review November 6, 2025 17:50
@stephanmg

Copy link
Copy Markdown
Collaborator

LGTM, thanks Polina!

@m-philipps m-philipps left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plots look good! Is there a way to do the visualisation without adding a column without header to the measurement table?

@plakrisenko

Copy link
Copy Markdown
Collaborator Author

The plots look good! Is there a way to do the visualisation without adding a column without header to the measurement table?

This column is not needed and can be removed. Do you think it could be helpful to move this information to the simulations table, or remove completely?

@stephanmg stephanmg left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.

@dilpath

dilpath commented Nov 11, 2025

Copy link
Copy Markdown
Collaborator

The plots look good! Is there a way to do the visualisation without adding a column without header to the measurement table?

This column is not needed and can be removed. Do you think it could be helpful to move this information to the simulations table, or remove completely?

I think it's nice to keep. I think the column in the visualization table is probably enough, since it can be used to both identify the figure that is reproduced, and the data that goes into the figure. Call it e.g. paper_figure.

@dilpath dilpath left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@plakrisenko plakrisenko linked an issue Nov 12, 2025 that may be closed by this pull request
14 tasks

@m-philipps m-philipps left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@plakrisenko
plakrisenko merged commit 69eda24 into master Nov 13, 2025
6 checks passed
@plakrisenko
plakrisenko deleted the lucarelli_visualization_spec branch November 21, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add missing visualization files

4 participants