2842 Adds alert role so error will be announced by screen reader - #6
Open
davezuckerman wants to merge 1 commit into
Open
davezuckerman wants to merge 1 commit into
davezuckerman wants to merge 1 commit into
Conversation
awilfox
reviewed
Sep 18, 2026
awilfox
left a comment
awilfox
left a comment
Member
There was a problem hiding this comment.
r+wc - we need to discuss adding the role to the warning container as well.
I have been looking high and low for any normative reference that I could give for this, since I know it's a common pattern and I know that it's something most do, but I couldn't find any. The only reference I could find to using role="alert" on warning conditions in addition to errors is on the Alert Example in the ARIA Authoring Practices Guide.
| </div> | ||
| <% end %> | ||
| <% if @exceptions.has_key?(:warnings) %> | ||
| <div class="alert alert-warning"> |
Member
There was a problem hiding this comment.
Should this also have a role="alert"?
Author
There was a problem hiding this comment.
Should that be a different ticket since this one specifically mentions error?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds alert role to _form_messages for screen readers
Related Ticket (JIRA or GitHub Issue)
[2842]
Summary
Fixes issue with error message not being announced to screen readers
Screenshots (if appropriate):
Types of changes
Checklist: