AP-856: scaffold a basic flask+celery app - #1
Merged
Merged
Conversation
anarchivist
force-pushed
the
AP-856
branch
6 times, most recently
from
September 11, 2026 03:49
caf0ada to
ace4e82
Compare
anarchivist
marked this pull request as ready for review
September 11, 2026 03:55
anarchivist
requested review from
awilfox,
danschmidt5189,
jason-raitz and
steve-sullivan
September 11, 2026 03:56
anarchivist
force-pushed
the
AP-856
branch
2 times, most recently
from
September 11, 2026 04:05
4986e98 to
312f342
Compare
* creates a simple app with a 2 routes: / and /health * creates a celery app that can be extended further * sets up Docker and Compose configuration to spin up the necessary services: db, app, worker, and redis * adds github actions workflows
awilfox
reviewed
Sep 12, 2026
awilfox
left a comment
awilfox
left a comment
Member
There was a problem hiding this comment.
r+wc: There's a lot of missing docstrings, but perhaps that's acceptable here. I didn't notate each one. Most of our other Python projects have both module- and function-level docstrings, so it was a bit surprising to have none here. I don't know if we need to manually pull in redis in PyProject. Tiny style nits. Otherwise, this looks good.
Member
Author
|
i'll take a pass to add docstrings before merging and make the requested changes. |
awilfox
approved these changes
Sep 14, 2026
awilfox
left a comment
awilfox
left a comment
Member
There was a problem hiding this comment.
r+wc few typo fixes, otherwise lgtm!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/and/health, and integrates celery into it