Repository navigation
T-21948 [CI] Expect the first sync to subscribe the static, spans and CloudTrail groups - #7
Merged
Merged
Conversation
… CloudTrail groups The frozen step that expected the recreated static group, aws/spans and the CloudTrail group to stay unsubscribed, and subscribed them through the API, goes away: Better Stack subscribes a recreated group again and starts each daily run from a clean account record. The wait for aws/spans moves ahead of the connect so the first sync already finds it. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The E2E froze a Better Stack behaviour that is now fixed: a log group deleted and recreated under the same name used to stay unsubscribed for good, and the sandbox's account record kept that history between runs, so the workflow expected the static group,
aws/spansand/aws/cloudtrail/better-stackto stay unsubscribed after the first sync and subscribed them through the API. Better Stack now subscribes a recreated group again, removes the subscription filters of a deleted source, and forgets an account record that no source has used for 8 hours. With that deployed, the frozen step fails on the first run that starts from a clean record.The workflow now expects the sync the connect enqueues to subscribe all four groups by itself: the run's and the static group through auto-subscribe,
aws/spansand the CloudTrail group by default. That holds whether the sandbox's account record was removed since the previous run or is reused with its history, since a reused record keeps the rows' intents and the teardown of the previous run's source only touched their statuses. The wait foraws/spansto exist moves ahead of the connect, so the first sync already finds it; the next sync would be 15 minutes later, past the step's deadline. The detour throughPOST /api/v2/sources/:id/aws-log-group-subscriptionsgoes with the frozen step, and the job summary describes the new expectation.The first dispatch run after the deploy (39404908357) shows the change: the sync subscribed the recreated static group right away, the frozen step failed on the first group it checked, and everything after it was skipped.
🤖 Generated with Claude Code